fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[Bug]: After updating to FluentUI 9.54.0, the runtime of all unit tests has significantly increased.

Open wendyyuanxie opened this issue 1 year ago • 2 comments

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (32) x64 AMD EPYC 7763 64-Core Processor
    Memory: 116.48 GB / 125.78 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash

Are you reporting Accessibility issue?

None

Reproduction

not sure how to share a repo at this case

Bug Description

After we update fluent package to version 9.54.0, the runtime of all the unit tests are increased significantly in our codebase. Especially, the unit tests are running against UI components. The other stuff are remain unchanged. We have notice this issue since fluent 9.53.0.

We are currently running fluent v9.46.6, and the runtime of our unit tests are around 40s: before-update-to-latest

After we update to fluent 9.54.0, and run the unit tests, the runtime now is around 230s, which is 6 times more:

after-update-to-latest

The testing library we are using is Jest (29.7.0), react-test-renderer (18.2.0), and we have react 18.2.0

This prevent us from updating our fluent package to the latest. Any help will be greatly appreciated!

Logs

No response

Requested priority

Blocking

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.

wendyyuanxie avatar Jun 14 '24 00:06 wendyyuanxie

BEFORE:

react-components version jest --ci / s
9.46.6 (current) 91s
9.54.1 580s / 𝚫 537% SLOWER 🚨

AFTER: resolved the issue within user codebase with following perf results:

react-components version jest --ci / s
9.46.6 (current) 91s
9.54.1 71s / 𝚫 22% FASTER

What was the issue:

pinned react-icons which created duplicates within node_modules -> causing gigantic perf slowdowns

Hotell avatar Jun 26 '24 15:06 Hotell

@wendyyuanxie please confirm if you're unblocked and we can close this. ty!

Hotell avatar Jun 26 '24 16:06 Hotell

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!