fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[Feature]: migrate repo to prettier v3

Open Hotell opened this issue 1 year ago • 3 comments

Library

all

Describe the feature that you would like added

We are running into intermittent issues on CI when invoking prettier.format within our nx workspace generators suite.

  • https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=343275&view=logs&j=e51d397b-0a7b-5b89-4b48-0052e021371d&t=88c41216-94ff-5ca8-d686-48ce16c1eefc
  • ci failure

Because @nx/devkit formatFiles is using prettier v3 the format call is awaited as v3 switched to async APIs(Breaking Change) but we have pinned prettier version within repo to v2. Now this api inconsistency might be the cause of those intermittent issues.

Task:

  • migrate whole repo to prettier v3
  • POC PR https://github.com/microsoft/fluentui/pull/31407
  • now because northstar uses prettier in various places where async behaviours cannot exists it creates a problematic way forward
  • additional blocker is storybook v6 which uses prettier v2 under the hood which might also cause inconsistencies

Blockers:

  • jest image https://github.com/jestjs/jest/issues/14305

Have you discussed this feature with our team

No response

Additional context

No response

Validations

  • [X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Priority

Normal

Related issues

  • https://github.com/nrwl/nx/issues/23501

Hotell avatar May 17 '24 09:05 Hotell

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".