fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

feat(react-nav-preview): Flagship Nav example

Open mltejera opened this issue 1 year ago • 4 comments

Adds styles for the nav component that will be turned into composed components and re-exported over the course of the next few weeks.

Adds the main nav story to the big kid story book.

Before: image

After: image

mltejera avatar Apr 30 '24 22:04 mltejera

📊 Bundle size report

✅ No changes found

fabricteam avatar Apr 30 '24 22:04 fabricteam

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Apr 30 '24 22:04 codesandbox-ci[bot]

Hello world!

lydsmit avatar May 01 '24 21:05 lydsmit

after running the initial release generator, I'd suggest to do that in separate PR as it's not a good practice to combine adding features with initial release.

tip: also please use github re-request review next time if you submitted changes based on the feedback, otherwise it wont show in peoples github inbox , thus will not be able to look it up. image

Hotell avatar May 03 '24 12:05 Hotell

after running the initial release generator, I'd suggest to do that in separate PR as it's not a good practice to combine adding features with initial release.

tip: also please use github re-request review next time if you submitted changes based on the feedback, otherwise it wont show in peoples github inbox , thus will not be able to look it up. image

Agreed that separation is good practice. I don't think I'm adding any features in this PR though? Just doing some pixel pushing and creating a realistic example.

mltejera avatar May 06 '24 15:05 mltejera