fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard
verified publisher icon microsoft

High Contrast Checkbox Web Component fix

Open procload opened this issue 1 year ago • 2 comments

Previous Behavior

High contrast styles for the checkbox were missing for the disabled state and mixed, indeterminate states:

image

New Behavior

Adds specific colors, backgrounds, and border colors for high contrast disabled and checked/mixed states: image

procload avatar Apr 23 '24 20:04 procload

📊 Bundle size report

✅ No changes found

fabricteam avatar Apr 23 '24 20:04 fabricteam

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Apr 23 '24 20:04 codesandbox-ci[bot]

@chrisdholt Thanks for the review. Feedback addressed by updating the selectors to use :is()

procload avatar May 17 '24 16:05 procload

@chrisdholt Did you have any other feedback on this, or can we merge this?

procload avatar Jun 04 '24 20:06 procload

@chrisdholt Did you have any other feedback on this, or can we merge this?

The DOM is changing quite a bit in https://github.com/microsoft/fluentui/pull/31468 and I believe that should be updated for High Contrast. We may just want to defer to the checkbox refactor PR for this to be resolved. @radium-v can advise on how close we are there (I think it's right there...)

chrisdholt avatar Jun 04 '24 20:06 chrisdholt