fluentui
fluentui copied to clipboard
feat: support numbers as v9 Option values
Previous Behavior
The value prop on the v9 <Option> component only accepted strings. Since this is only used for matching with selectedOptions and as data on onOptionSelect, we should be able to accept number values as well.
New Behavior
allows value to be string | number (and updates associated types & tests)
Related Issue(s)
- Fixes #30571
Perf Analysis (@fluentui/react-components)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 632 | 5000 | |
| Button | mount | 296 | 308 | 5000 | |
| Field | mount | 1130 | 1092 | 5000 | |
| FluentProvider | mount | 708 | 680 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 70 | 61 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 70 | 10 | |
| MakeStyles | mount | 860 | 883 | 50000 | |
| Persona | mount | 1769 | 1675 | 5000 | |
| SpinButton | mount | 1370 | 1386 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main
This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI!