fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[NeutralColor]: Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme

Open rgcircum opened this issue 1 year ago • 8 comments

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme.

Actually, method createLightTheme/createDarkTheme do not provided any possibility to change Neutral colors (like Fluent UI8).

It's a problem if the brand color contains a colored grey + primary color.

The only current way i finded, is create a complete Fluent UI 8 theme (https://codepen.io/pen) and use createV9Theme from @fluentui/react-migration-v8-v9 package

It's not a good way.

Possible solution :

Pass a greys Ramp to method.

createLightTheme: (brand: BrandVariants, greys? : Greys) => Theme

PS : For me it'a bug, i have marked this as feature

Have you discussed this feature with our team

No response

Additional context

No response

Validations

  • [X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Priority

Normal

rgcircum avatar Feb 02 '24 09:02 rgcircum

@ValentinaKozlova you have any news for this ?

rgcircum avatar May 22 '24 16:05 rgcircum

@ValentinaKozlova you have any news for this ?

Not yet. It needs PM review

ValentinaKozlova avatar May 23 '24 12:05 ValentinaKozlova

@brandonthomas @EdDaWord do you have any plans for this feature in the token pipeline?

tudorpopams avatar Jun 03 '24 15:06 tudorpopams

@ValentinaKozlova @brandonthomas @EdDaWord you have any news for this ?

We still can't create a dark theme with anything other than fixed black theme.

rgcircum avatar Aug 01 '24 07:08 rgcircum

@ValentinaKozlova @brandonthomas @EdDaWord you have any news for this ?

It is still not possible to create dark themes correctly.

rgcircum avatar Jun 12 '25 09:06 rgcircum

keep open

rgcircum avatar Jun 12 '25 09:06 rgcircum

@brandonthomas @EdDaWord do you have any plans for this feature in the token pipeline?

Hi @tudorpopams - I spoke with Brandon, and there are no plans to address this request. Their team isn't maintaining the token pipeline.

@miroslavstastny, Brandon mentioned you might have more context about this feature request?

gouttierre avatar Jun 13 '25 13:06 gouttierre