fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

30127 - TeachingPopover updates

Open Mitch-At-Work opened this issue 1 year ago • 5 comments

New Behavior

  • Carousel functionality has been unified into TeachingPopoverCarousel
  • Moved teaching popover page context to within carousel
  • Render page count nav icons as individual components (not slots)
  • New 'TeachingPopoverFooter' to replace TeachingPopverActions

Related Issue(s)

  • Fixes #30127

Mitch-At-Work avatar Jan 29 '24 21:01 Mitch-At-Work

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jan 29 '24 21:01 codesandbox-ci[bot]

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
328 B
global-context
createContextSelector
537 B
339 B
react-accordion
Accordion (including children components)
100.127 kB
30.426 kB
react-alert
Alert
83.737 kB
23.474 kB
react-avatar
Avatar
50.175 kB
15.944 kB
react-avatar
AvatarGroup
19.704 kB
7.796 kB
react-avatar
AvatarGroupItem
64.831 kB
20.274 kB
react-badge
Badge
26.905 kB
8.729 kB
react-badge
CounterBadge
27.806 kB
9.024 kB
react-badge
PresenceBadge
25.311 kB
9.306 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
115.48 kB
31.84 kB
react-button
Button
39.513 kB
11.169 kB
react-button
CompoundButton
46.874 kB
12.661 kB
react-button
MenuButton
44.292 kB
12.542 kB
react-button
SplitButton
52.306 kB
14.134 kB
react-button
ToggleButton
56.559 kB
13.068 kB
react-calendar-compat
Calendar Compat
152.073 kB
39.83 kB
react-card
Card - All
101.557 kB
28.932 kB
react-card
Card
96.382 kB
27.401 kB
react-card
CardFooter
13.064 kB
5.385 kB
react-card
CardHeader
15.307 kB
6.143 kB
react-card
CardPreview
14.015 kB
5.752 kB
react-checkbox
Checkbox
35.656 kB
12.07 kB
react-combobox
Combobox (including child components)
102.463 kB
33.101 kB
react-combobox
Dropdown (including child components)
103.837 kB
33.038 kB
react-components
react-components: Button, FluentProvider & webLightTheme
71.098 kB
20.514 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.585 kB
14.351 kB
react-datepicker-compat
DatePicker Compat
224.523 kB
62.939 kB
react-dialog
Dialog (including children components)
100.93 kB
29.924 kB
react-divider
Divider
20.82 kB
7.763 kB
react-field
Field
22.542 kB
8.608 kB
react-image
Image
15.745 kB
6.23 kB
react-infobutton
InfoButton
138.696 kB
43.398 kB
react-infobutton
InfoLabel
142.497 kB
44.627 kB
react-input
Input
26.891 kB
9.119 kB
react-jsx-runtime
Classic Pragma
1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime
3.783 kB
1.648 kB
react-jsx-runtime
JSX Runtime
4.377 kB
1.881 kB
react-label
Label
14.266 kB
5.828 kB
react-link
Link
17.082 kB
6.911 kB
react-menu
Menu (including children components)
149.428 kB
45.509 kB
react-menu
Menu (including selectable components)
152.114 kB
46.021 kB
react-message-bar
MessageBar (all components)
25.566 kB
9.131 kB
react-overflow
hooks only
12.862 kB
4.827 kB
react-persona
Persona
57.066 kB
17.821 kB
react-popover
Popover
126.886 kB
39.806 kB
react-portal
Portal
13.633 kB
4.869 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-positioning
usePositioning
26.398 kB
9.539 kB
react-progress
ProgressBar
17.428 kB
6.898 kB
react-provider
FluentProvider
23.759 kB
8.657 kB
react-radio
Radio
32.95 kB
10.251 kB
react-radio
RadioGroup
15.354 kB
6.265 kB
react-select
Select
28.609 kB
10.205 kB
react-slider
Slider
39.949 kB
12.968 kB
react-spinbutton
SpinButton
36.774 kB
11.788 kB
react-spinner
Spinner
24.696 kB
8.341 kB
react-switch
Switch
35.14 kB
11.2 kB
react-table
DataGrid
165.191 kB
45.909 kB
react-table
Table (Primitives only)
45.324 kB
14.116 kB
react-table
Table as DataGrid
136.573 kB
36.817 kB
react-table
Table (Selection only)
76.334 kB
20.552 kB
react-table
Table (Sort only)
74.977 kB
20.154 kB
react-tags
InteractionTag
15.259 kB
6.058 kB
react-tags
Tag
29.982 kB
9.439 kB
react-tags
TagGroup
80.556 kB
24.027 kB
react-text
Text - Default
16.705 kB
6.569 kB
react-text
Text - Wrappers
19.878 kB
6.896 kB
react-textarea
Textarea
30.947 kB
10.476 kB
react-timepicker-compat
TimePicker
104.484 kB
34.49 kB
react-toast
Toast (including Toaster)
100.198 kB
29.76 kB
react-tooltip
Tooltip
54.58 kB
19.188 kB
react-utilities
SSRProvider
180 B
160 B
🤖 This report was generated against 9ec06b71971a4abe14604589fcccd8c082baaca1

fabricteam avatar Jan 29 '24 21:01 fabricteam

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 660 622 5000
Button mount 302 300 5000
Field mount 1125 1142 5000
FluentProvider mount 691 698 5000
FluentProviderWithTheme mount 76 78 10
FluentProviderWithTheme virtual-rerender 62 61 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 92 10
MakeStyles mount 880 846 50000
Persona mount 1801 1729 5000
SpinButton mount 1391 1428 5000

fabricteam avatar Jan 29 '24 21:01 fabricteam

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ea2ac442b26360c3e0e86a0225ac4570c89f636 (build)

size-auditor[bot] avatar Jan 29 '24 22:01 size-auditor[bot]

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam avatar Feb 14 '24 19:02 fabricteam