fluentui
fluentui copied to clipboard
docs (react-swatch-picker): SPEC
Added SPEC.md
- For layout I made union type of
row
andgrid
with appropriate props -columnCount
forgrid
andresponsive
forrow
.
Perf Analysis (@fluentui/react-components
)
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 62 | 62 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 615 | 641 | 5000 | |
Button | mount | 307 | 305 | 5000 | |
Field | mount | 1124 | 1125 | 5000 | |
FluentProvider | mount | 688 | 707 | 5000 | |
FluentProviderWithTheme | mount | 76 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender | 62 | 62 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 70 | 10 | |
InfoButton | mount | 14 | 8 | 5000 | |
MakeStyles | mount | 860 | 851 | 50000 | |
Persona | mount | 1741 | 1689 | 5000 | |
SpinButton | mount | 1335 | 1392 | 5000 |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
🕵 fluentuiv8 No visual regressions between this PR and main
Perf Analysis (@fluentui/react-northstar
)
:warning: 1 potential perf regressions detected
Potential regressions comparing to master
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
TreeWith60ListItems.default | 86 | 85 | 1.01:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AvatarMinimalPerf.default | 131 | 98 | 1.34:1 |
ChatDuplicateMessagesPerf.default | 161 | 139 | 1.16:1 |
RefMinimalPerf.default | 113 | 103 | 1.1:1 |
AccordionMinimalPerf.default | 83 | 76 | 1.09:1 |
LayoutMinimalPerf.default | 204 | 187 | 1.09:1 |
AlertMinimalPerf.default | 162 | 150 | 1.08:1 |
ChatWithPopoverPerf.default | 195 | 181 | 1.08:1 |
DropdownManyItemsPerf.default | 421 | 391 | 1.08:1 |
AttachmentMinimalPerf.default | 87 | 82 | 1.06:1 |
ListMinimalPerf.default | 321 | 302 | 1.06:1 |
BoxMinimalPerf.default | 195 | 185 | 1.05:1 |
ButtonOverridesMissPerf.default | 677 | 645 | 1.05:1 |
ButtonSlotsPerf.default | 334 | 318 | 1.05:1 |
DialogMinimalPerf.default | 456 | 436 | 1.05:1 |
DividerMinimalPerf.default | 204 | 195 | 1.05:1 |
FlexMinimalPerf.default | 158 | 151 | 1.05:1 |
StatusMinimalPerf.default | 398 | 379 | 1.05:1 |
AttachmentSlotsPerf.default | 649 | 633 | 1.03:1 |
ImageMinimalPerf.default | 229 | 222 | 1.03:1 |
TreeMinimalPerf.default | 480 | 465 | 1.03:1 |
CardMinimalPerf.default | 303 | 298 | 1.02:1 |
ChatMinimalPerf.default | 434 | 427 | 1.02:1 |
FormMinimalPerf.default | 228 | 224 | 1.02:1 |
HeaderSlotsPerf.default | 470 | 463 | 1.02:1 |
ItemLayoutMinimalPerf.default | 699 | 682 | 1.02:1 |
ListWith60ListItems.default | 359 | 353 | 1.02:1 |
MenuMinimalPerf.default | 506 | 498 | 1.02:1 |
RosterPerf.default | 1615 | 1579 | 1.02:1 |
ProviderMergeThemesPerf.default | 653 | 642 | 1.02:1 |
ReactionMinimalPerf.default | 214 | 209 | 1.02:1 |
EmbedMinimalPerf.default | 1885 | 1871 | 1.01:1 |
SliderMinimalPerf.default | 741 | 732 | 1.01:1 |
SplitButtonMinimalPerf.default | 2237 | 2209 | 1.01:1 |
IconMinimalPerf.default | 380 | 377 | 1.01:1 |
TextMinimalPerf.default | 193 | 191 | 1.01:1 |
VideoMinimalPerf.default | 435 | 432 | 1.01:1 |
DatepickerMinimalPerf.default | 3549 | 3544 | 1:1 |
DropdownMinimalPerf.default | 1402 | 1408 | 1:1 |
HeaderMinimalPerf.default | 203 | 204 | 1:1 |
InputMinimalPerf.default | 539 | 539 | 1:1 |
MenuButtonMinimalPerf.default | 959 | 958 | 1:1 |
ProviderMinimalPerf.default | 202 | 203 | 1:1 |
RadioGroupMinimalPerf.default | 255 | 256 | 1:1 |
ToolbarMinimalPerf.default | 521 | 522 | 1:1 |
CarouselMinimalPerf.default | 258 | 261 | 0.99:1 |
CheckboxMinimalPerf.default | 1108 | 1119 | 0.99:1 |
PopupMinimalPerf.default | 348 | 351 | 0.99:1 |
SegmentMinimalPerf.default | 195 | 197 | 0.99:1 |
TextAreaMinimalPerf.default | 284 | 287 | 0.99:1 |
CustomToolbarPrototype.default | 1487 | 1499 | 0.99:1 |
ButtonMinimalPerf.default | 87 | 89 | 0.98:1 |
TableManyItemsPerf.default | 1079 | 1104 | 0.98:1 |
TableMinimalPerf.default | 232 | 236 | 0.98:1 |
AnimationMinimalPerf.default | 286 | 295 | 0.97:1 |
GridMinimalPerf.default | 183 | 189 | 0.97:1 |
LabelMinimalPerf.default | 205 | 212 | 0.97:1 |
SkeletonMinimalPerf.default | 191 | 196 | 0.97:1 |
TooltipMinimalPerf.default | 1280 | 1313 | 0.97:1 |
ListNestedPerf.default | 302 | 314 | 0.96:1 |
LoaderMinimalPerf.default | 197 | 207 | 0.95:1 |
PortalMinimalPerf.default | 80 | 84 | 0.95:1 |
ListCommonPerf.default | 359 | 392 | 0.92:1 |
🕵 FluentUIV0 No visual regressions between this PR and main
🕵 fluentuiv9 No visual regressions between this PR and main
Perf Analysis (@fluentui/react
)
No significant results to display.
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 628 | 625 | 5000 | |
Breadcrumb | mount | 1639 | 1652 | 1000 | |
Checkbox | mount | 1650 | 1675 | 5000 | |
CheckboxBase | mount | 1465 | 1490 | 5000 | |
ChoiceGroup | mount | 2938 | 2913 | 5000 | |
ComboBox | mount | 675 | 626 | 1000 | |
CommandBar | mount | 6047 | 6081 | 1000 | |
ContextualMenu | mount | 11778 | 11965 | 1000 | |
DefaultButton | mount | 741 | 744 | 5000 | |
DetailsRow | mount | 2193 | 2153 | 5000 | |
DetailsRowFast | mount | 2152 | 2162 | 5000 | |
DetailsRowNoStyles | mount | 1985 | 1975 | 5000 | |
Dialog | mount | 2763 | 2612 | 1000 | |
DocumentCardTitle | mount | 222 | 205 | 1000 | |
Dropdown | mount | 1971 | 1979 | 5000 | |
FocusTrapZone | mount | 1172 | 1125 | 5000 | |
FocusZone | mount | 1062 | 1054 | 5000 | |
GroupedList | mount | 40977 | 40950 | 2 | |
GroupedList | virtual-rerender | 19708 | 19516 | 2 | |
GroupedList | virtual-rerender-with-unmount | 49682 | 50060 | 2 | |
GroupedListV2 | mount | 225 | 218 | 2 | |
GroupedListV2 | virtual-rerender | 209 | 207 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 223 | 231 | 2 | |
IconButton | mount | 1082 | 1079 | 5000 | |
Label | mount | 327 | 331 | 5000 | |
Layer | mount | 2629 | 2718 | 5000 | |
Link | mount | 395 | 384 | 5000 | |
MenuButton | mount | 943 | 923 | 5000 | |
MessageBar | mount | 21127 | 21268 | 5000 | |
Nav | mount | 1888 | 1889 | 1000 | |
OverflowSet | mount | 766 | 759 | 5000 | |
Panel | mount | 1761 | 1789 | 1000 | |
Persona | mount | 744 | 729 | 1000 | |
Pivot | mount | 829 | 883 | 1000 | |
PrimaryButton | mount | 810 | 839 | 5000 | |
Rating | mount | 4577 | 4480 | 5000 | |
SearchBox | mount | 898 | 884 | 5000 | |
Shimmer | mount | 1858 | 1803 | 5000 | |
Slider | mount | 1270 | 1288 | 5000 | |
SpinButton | mount | 2847 | 2874 | 5000 | |
Spinner | mount | 383 | 376 | 5000 | |
SplitButton | mount | 1808 | 1836 | 5000 | |
Stack | mount | 406 | 402 | 5000 | |
StackWithIntrinsicChildren | mount | 849 | 876 | 5000 | |
StackWithTextChildren | mount | 2568 | 2588 | 5000 | |
SwatchColorPicker | mount | 5965 | 6027 | 5000 | |
TagPicker | mount | 1394 | 1447 | 5000 | |
Text | mount | 360 | 379 | 5000 | |
TextField | mount | 916 | 931 | 5000 | |
ThemeProvider | mount | 826 | 808 | 5000 | |
ThemeProvider | virtual-rerender | 595 | 587 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1242 | 1249 | 5000 | |
Toggle | mount | 617 | 609 | 5000 | |
buttonNative | mount | 186 | 193 | 5000 |
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: e2012e6d53305fba8990c25833c937d2af58d4fd (build)
@layershifter to review on behalf of teams-prg
I had an offline discussion with @ValentinaKozlova about the spec, will do another round once comments will be addressed.