fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[Bug]: Api extractor output does not match ci

Open sopranopillow opened this issue 1 year ago • 1 comments

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (20) x64 Intel(R) Core(TM) i9-10900K CPU @ 3.70GHz
    Memory: 51.01 GB / 62.66 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 104.0

Are you reporting Accessibility issue?

no

Reproduction

Cloning the repo and running yarn buildci gives a bunch of api changes.

Bug Description

Actual Behavior

Getting many api changes: image

After talking to @TristanWatanabe, he mentioned this is due to a recent PR https://github.com/microsoft/fluentui/pull/27936 that bumps api-extractor. This bump included this change:

image

therefore our current way of dealing with path aliases is not working correctly:

image

From this, we get a removal of the following due to the api extractor not giving the same output as ci (also the local output is wrong)

image

Expected Behavior

CI and local api extractor should provide the same output.

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.

sopranopillow avatar May 31 '23 20:05 sopranopillow

For extra context, I believe this was the PR introduced in @microsoft/api-extractor version 7.21.0 that changed the behavior with how TS path aliases are handled: https://github.com/microsoft/rushstack/pull/3321

TristanWatanabe avatar May 31 '23 21:05 TristanWatanabe

:tada:This issue was addressed in #28215, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot

:tada:This issue was addressed in #28215, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot