fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Expose disabled property in IColorCellProps

Open jessie782 opened this issue 2 years ago • 8 comments
trafficstars

Previous Behavior

The disabled property is not exported in the IColorCellProps interface.

New Behavior

The disabled property is exported as part of the IColorCellProps interface to allow users to disable color cells.

Related Issue(s)

  • Fixes #

jessie782 avatar May 26 '23 21:05 jessie782

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-SwatchColorPicker 182.919 kB 182.943 kB ExceedsBaseline     24 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 4a9f03c96b04bd9cca11b7718a3f7f60bf78d2ee (build)

size-auditor[bot] avatar May 26 '23 21:05 size-auditor[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e304887216a4844f506ab88189391ef7773b3d5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar May 26 '23 21:05 codesandbox-ci[bot]

📊 Bundle size report

🤖 This report was generated against 0868df85405025c1488c8b0f8285ead56c379626

fabricteam avatar May 26 '23 21:05 fabricteam

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 641 5000
Breadcrumb mount 1667 1681 1000
Checkbox mount 1723 1705 5000
CheckboxBase mount 1497 1508 5000
ChoiceGroup mount 2911 2976 5000
ComboBox mount 670 656 1000
CommandBar mount 6224 6294 1000
ContextualMenu mount 12905 12920 1000
DefaultButton mount 741 746 5000
DetailsRow mount 2197 2144 5000
DetailsRowFast mount 2208 2225 5000
DetailsRowNoStyles mount 2026 2030 5000
Dialog mount 2615 2627 1000
DocumentCardTitle mount 237 228 1000
Dropdown mount 1985 2000 5000
FocusTrapZone mount 1128 1123 5000
FocusZone mount 1061 1041 5000
GroupedList mount 41227 41695 2
GroupedList virtual-rerender 19869 19923 2
GroupedList virtual-rerender-with-unmount 51089 51578 2
GroupedListV2 mount 235 228 2
GroupedListV2 virtual-rerender 213 220 2
GroupedListV2 virtual-rerender-with-unmount 235 239 2
IconButton mount 1101 1089 5000
Label mount 342 333 5000
Layer mount 2717 2715 5000
Link mount 397 415 5000
MenuButton mount 965 938 5000
MessageBar mount 21480 21619 5000
Nav mount 1927 1950 1000
OverflowSet mount 766 767 5000
Panel mount 1747 1767 1000
Persona mount 751 764 1000
Pivot mount 883 877 1000
PrimaryButton mount 862 856 5000
Rating mount 4584 4620 5000
SearchBox mount 938 909 5000
Shimmer mount 1878 1863 5000
Slider mount 1371 1319 5000
SpinButton mount 2888 2849 5000
Spinner mount 387 396 5000
SplitButton mount 1850 1851 5000
Stack mount 424 417 5000
StackWithIntrinsicChildren mount 870 870 5000
StackWithTextChildren mount 2676 2695 5000
SwatchColorPicker mount 6123 6182 5000
TagPicker mount 1450 1424 5000
Text mount 384 384 5000
TextField mount 943 942 5000
ThemeProvider mount 849 834 5000
ThemeProvider virtual-rerender 593 588 5000
ThemeProvider virtual-rerender-with-unmount 1287 1289 5000
Toggle mount 631 608 5000
buttonNative mount 198 195 5000

fabricteam avatar May 26 '23 21:05 fabricteam

@jessie782 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

jessie782 avatar Jun 01 '23 17:06 jessie782

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam avatar Jun 01 '23 21:06 fabricteam

/azp run Fluent UI React - PR and CI

khmakoto avatar Jun 01 '23 22:06 khmakoto

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 01 '23 22:06 azure-pipelines[bot]

/azp run Fluent UI React - PR and CI

khmakoto avatar Jun 02 '23 21:06 khmakoto

Commenter does not have sufficient privileges for PR 28015 in repo microsoft/fluentui

azure-pipelines[bot] avatar Jun 02 '23 21:06 azure-pipelines[bot]

/azp run Fluent UI React - PR and CI

GeoffCoxMSFT avatar Jun 02 '23 21:06 GeoffCoxMSFT

Commenter does not have sufficient privileges for PR 28015 in repo microsoft/fluentui

azure-pipelines[bot] avatar Jun 02 '23 21:06 azure-pipelines[bot]

/azp run Fluent UI React - PR and CI

khmakoto avatar Jun 02 '23 22:06 khmakoto

Commenter does not have sufficient privileges for PR 28015 in repo microsoft/fluentui

azure-pipelines[bot] avatar Jun 02 '23 22:06 azure-pipelines[bot]

/azp run Fluent UI React - PR and CI

khmakoto avatar Jun 05 '23 18:06 khmakoto

Commenter does not have sufficient privileges for PR 28015 in repo microsoft/fluentui

azure-pipelines[bot] avatar Jun 05 '23 18:06 azure-pipelines[bot]

/azp run Fluent UI React - PR and CI

micahgodbolt avatar Jun 05 '23 18:06 micahgodbolt

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 05 '23 18:06 azure-pipelines[bot]

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 06 '23 07:06 msft-fluent-ui-bot