fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Overflow divider fix

Open ValentinaKozlova opened this issue 1 year ago • 4 comments

Previous Behavior

divider-bug If there are custom margins/paddings it, also, breaks overflow logic divider-bug-0

New Behavior

divider-fix-0

Related Issue(s)

  • Fixes #

ValentinaKozlova avatar May 26 '23 09:05 ValentinaKozlova

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 590 595 5000
Button mount 301 298 5000
Field mount 1062 1049 5000
FluentProvider mount 631 658 5000
FluentProviderWithTheme mount 85 89 10
FluentProviderWithTheme virtual-rerender 77 85 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 74 10
InfoButton mount 17 11 5000
MakeStyles mount 851 865 50000
Persona mount 1612 1626 5000
SpinButton mount 1351 1342 5000

fabricteam avatar May 26 '23 09:05 fabricteam

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cf6b94ba6559236150bc1f1814b023607edaeb20 (build)

size-auditor[bot] avatar May 26 '23 09:05 size-auditor[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cbf1d8ab14725c60274e4e84002cbc0ece8133a6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar May 26 '23 09:05 codesandbox-ci[bot]

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
priority-overflow
createOverflowManager
3.194 kB
1.315 kB
4.204 kB
1.656 kB
1.01 kB
341 B
react-overflow
hooks only
11.206 kB
4.266 kB
12.461 kB
4.609 kB
1.255 kB
343 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
65.162 kB
17.952 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
210.103 kB
58.624 kB
react-components
react-components: FluentProvider & webLightTheme
36.395 kB
11.996 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
🤖 This report was generated against cf6b94ba6559236150bc1f1814b023607edaeb20

fabricteam avatar May 26 '23 09:05 fabricteam

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot

:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot avatar Jun 21 '23 07:06 msft-fluent-ui-bot