fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Expose getFileTypeIconAsURL helper for react-file-type-icons

Open NotWoods opened this issue 1 year ago • 5 comments

Previous Behavior

File Type Icons can't be used with Fluent 9 unless you import Fluent 8 <Icon /> or use React to dangerously set inner HTML.

New Behavior

Expose a new helper method so Fluent 9 code can use <img src={getFileTypeIconAsURL()} />.

Related Issue(s)

  • Fixes #

NotWoods avatar May 22 '23 19:05 NotWoods

📊 Bundle size report

🤖 This report was generated against c0214bcb7d9369db75eb842adf4253893bc0e160

fabricteam avatar May 22 '23 20:05 fabricteam

cc: @behowell for visibility

paulgildea avatar May 22 '23 20:05 paulgildea

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: ab901891c51f8bd5d1a5099e66011c9c84372566

Possible causes

  • The baseline build ab901891c51f8bd5d1a5099e66011c9c84372566 is broken
  • The Size Auditor run for the baseline build ab901891c51f8bd5d1a5099e66011c9c84372566 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

size-auditor[bot] avatar May 22 '23 20:05 size-auditor[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acf0be697c588923e8092efd97288dc5f755df7a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar May 22 '23 20:05 codesandbox-ci[bot]

@micahgodbolt is this something to help with while Ben is oof? cc: @grace-zou

paulgildea avatar Jun 01 '23 17:06 paulgildea

/azp run

micahgodbolt avatar Jun 08 '23 21:06 micahgodbolt

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Jun 08 '23 21:06 azure-pipelines[bot]

I have approved and merged this PR: #27336. Can you pull from master and update this PR?

tomi-msft avatar Jun 09 '23 21:06 tomi-msft