microsoft
Users/procload/add select as web component
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: 06a52667968547f07b360da4d1d6f65891b7496f (build)
![size-auditor[bot] avatar](https://avatars.githubusercontent.com/in/13711?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 1f8800addbef841adb9c41c7fb5dd84694e34fa1:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is ready for review. I'm probably missing a few native Select attributes in here, but I tried to capture them all. I'm also still curious if I added the AriaGlobal mixin from FAST correctly. You can find it here: https://github.com/microsoft/fluentui/pull/27635/files#diff-690522150a9d3d3768eb62160ca05b9ad8dba7e095ca53a3dc625dd31982bcc4R14 and https://github.com/microsoft/fluentui/pull/27635/files#diff-690522150a9d3d3768eb62160ca05b9ad8dba7e095ca53a3dc625dd31982bcc4R204-R206
Design review
| # | Issue | Category |
|---|---|---|
| 1 | Chevron icon vertical alignment is off, should be centered | Sizing |
| 2 | Left and right padding should change according to controlSize, as in Medium: --spacingHorizontalMNudge + --spacingHorizontalXXS, Small: spacingHorizontalSNudge + --spacingHorizontalXXS, Large: spacingHorizontalM + --spacingHorizontalSNudge | Sizing |
| 3 | Cursor should change to pointer on hover | Accessibility |
Question about the label: I might be misunderstanding something, but I was under the impression that we should learn towards using the Field component to display these form controls in combination with a label or message for accessibility reasons rather than using a per-component label property. Do we still need to build it in as a property? Curious what the best practice is if we want to recommend Fields over Labels
Marking this again as Draft as it's becoming increasingly complicated and I don't have the bandwidth (and knowledge) to complete it in a timely manner. There's more pressing components to work on, but we can pick this up again once we're not under pressure on other priorities.
