fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[Feature]: Add a file picker control (Input does not support type `file`)

Open jurokapsiar opened this issue 2 years ago • 13 comments

Library

React Components / v9 (@fluentui/react-components)

System Info

any system

Are you reporting Accessibility issue?

no

Reproduction

https://react.fluentui.dev/?path=/docs/components-input--default

Bug Description

Actual Behavior

It is not possible to use file type

Expected Behavior

file type is supported

Logs

No response

Requested priority

Normal

Products/sites affected

Teams

Are you willing to submit a PR to fix?

no

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.

jurokapsiar avatar Feb 14 '23 10:02 jurokapsiar

Input explicitly excludes certain types where Fluent supports a component that fills that role (e.g., button, checkbox and radio). We do not currently support a "file picker" in Fluent and I'm asking around to see if there are plans for one.

In the meantime I change the "type" in DevTools and get this:

file_input

which doesn't fit with Fluent's design.

Before adding file as an allowed type for Input I want to understand if there are plans for a dedicated control and what the timeline for that will be. I'd also like to get design feedback on type="file" as-is.

spmonahan avatar Feb 27 '23 22:02 spmonahan

Talked with design and they do not have designs for a file picker but are open to adding them.

@jurokapsiar what do you think about getting designs for a FilePicker rather than adding the type to Input?

spmonahan avatar Mar 07 '23 17:03 spmonahan

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

is it closed? no file input?

robertodraGit avatar Dec 04 '23 14:12 robertodraGit

It was closed automatically by our bot. Reopening.

spmonahan avatar Dec 04 '23 15:12 spmonahan

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Updated the title to clarify that the request is to add a file picker control; not to add support for picking files to the Input control.

behowell avatar Jun 04 '24 17:06 behowell

📢

  • Net new item + added to the React v9 Roadmap for transparency
  • Viktor has spoken with Ben to get background context.
  • In order to get this started, we will require resources from the design team. (PM to speak with DPM)

cc @jurokapsiar , @JustSlone , @tudorpopams , @paulgildea

gouttierre avatar Jun 20 '24 13:06 gouttierre

📢

  • Due to the limited design resources at the moment, and the requests' given priority level is set at normal; we will have to pause this task.
  • Toshie will lend a hand once back from PTO (2~weeks) to update the spec.
  • Marcos is driving the development and will pick this request up once the spec is ready.

cc ~ @marcosmoura , @tudorpopams , @JustSlone

gouttierre avatar Aug 23 '24 14:08 gouttierre