fluentui
fluentui copied to clipboard
fix: Remove SwitchField's labelPosition prop, as it has no effect
Current Behavior
The SwitchField control inherits the labelPosition prop from Switch. However, the label prop goes to the field and not the Switch, and so the Switch's labelPosition prop has no effect.
New Behavior
Omit the labelPosition prop from SwitchField to avoid confusion.
Related Issue(s)
- Fixes #24685
📊 Bundle size report
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
188.672 kB52.359 kB |
| react-components react-components: FluentProvider & webLightTheme |
33.394 kB11.007 kB |
| react-portal-compat PortalCompatProvider |
5.851 kB1.964 kB |
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: 92bc886e6e3e5ec43847752941456666eb69d32b (build)
Perf Analysis (@fluentui/react-components)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1605 | 1539 | 5000 | |
| Button | mount | 1190 | 1186 | 5000 | |
| FluentProvider | mount | 1907 | 1909 | 5000 | |
| FluentProviderWithTheme | mount | 735 | 752 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 698 | 712 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 736 | 737 | 10 | |
| MakeStyles | mount | 2236 | 2337 | 50000 | |
| SpinButton | mount | 3013 | 3005 | 5000 |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 6cfe3d5a8c39995213c8d86311e022c3b0e6ef36:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |