fluentui
fluentui copied to clipboard
Published
20 hours ago •
microsoft
microsoft
react-18-tests-v8: Add type-checking again
trafficstars
Changes:
- Was running into the error below on CI when
@fluentui/react-18-tests-v8package was running itstype-checkscript because this package depends on v8 and thetype-checkscript was running before v8 had successfully been built. This change in thelage.config.jsfile ensures that v8 completes itsbuildstep before running the test appstype-check.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(7,8): error TS2307: Cannot find module '@fluentui/react/lib/ContextualMenu' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(8,43): error TS2307: Cannot find module '@fluentui/react/lib/Button' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(9,36): error TS2307: Cannot find module '@fluentui/react/lib/FocusZone' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(10,32): error TS2307: Cannot find module '@fluentui/react/lib/Styling' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(11,21): error TS2307: Cannot find module '@fluentui/react/lib/Utilities' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenuExample.tsx(12,26): error TS2307: Cannot find module '@fluentui/react-hooks' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/App.tsx(2,70): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/App.tsx(3,28): error TS2307: Cannot find module '@fluentui/react-hooks' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenu.e2e.tsx(3,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
verb @fluentui/merge-styles build | Analysis will use the bundled TypeScript version 4.3.5
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenu.test.tsx(4,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
verb @fluentui/react-window-provider build | [5:20:07 PM] ■ Extracting Public API surface from '/mnt/vss/_work/1/s/packages/react-window-provider/lib/index.d.ts'
verb @fluentui/react-18-tests-v8 type-check | src/components/ContextualMenu/ContextualMenu.e2e.tsx(3,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
verb @fluentui/react-18-tests-v8 type-check | npm ERR! code ELIFECYCLE
verb @fluentui/react-18-tests-v8 type-check | npm ERR! errno 1
verb @fluentui/react-18-tests-v8 type-check | npm ERR! @fluentui/[email protected] type-check: `tsc -b tsconfig.json`
verb @fluentui/react-18-tests-v8 type-check | npm ERR! Exit status 1
verb @fluentui/react-18-tests-v8 type-check | npm ERR!
verb @fluentui/react-18-tests-v8 type-check | npm ERR! Failed at the @fluentui/[email protected] type-check script.
verb @fluentui/react-18-tests-v8 type-check | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
verb @fluentui/react-18-tests-v8 type-check |
verb @fluentui/react-18-tests-v8 type-check | npm ERR! A complete log of this run can be found in:
verb @fluentui/react-18-tests-v8 type-check | npm ERR! /home/cloudtest/.npm/_logs/2022-09-19T17_20_07_364Z-debug.log
info @fluentui/react-18-tests-v8 type-check ❌ fail
Follow-up to #24637
📊 Bundle size report
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| global-context createContext |
533 B341 B |
| global-context createContextSelector |
554 B348 B |
| priority-overflow createOverflowManager |
2.936 kB1.212 kB |
| react-accordion Accordion (including children components) |
78.914 kB24.06 kB |
| react-alert Alert |
83.511 kB20.921 kB |
| react-avatar Avatar |
48.381 kB13.696 kB |
| react-avatar AvatarGroup |
14.95 kB5.989 kB |
| react-avatar AvatarGroupItem |
68.349 kB19.039 kB |
| react-badge Badge |
22.6 kB7.205 kB |
| react-badge CounterBadge |
23.503 kB7.497 kB |
| react-badge PresenceBadge |
24.05 kB7.067 kB |
| react-button Button |
36.119 kB9.647 kB |
| react-button CompoundButton |
43.144 kB10.86 kB |
| react-button MenuButton |
38.813 kB10.551 kB |
| react-button SplitButton |
46.228 kB11.933 kB |
| react-button ToggleButton |
51.888 kB11.127 kB |
| react-card Card - All |
67.002 kB19.261 kB |
| react-card Card |
62.684 kB18.177 kB |
| react-card CardFooter |
8.561 kB3.601 kB |
| react-card CardHeader |
9.604 kB3.94 kB |
| react-card CardPreview |
8.662 kB3.656 kB |
| react-combobox Combobox (including child components) |
74.636 kB24.186 kB |
| react-combobox Dropdown (including child components) |
74.236 kB24.086 kB |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
188.672 kB52.359 kB |
| react-components react-components: FluentProvider & webLightTheme |
33.394 kB11.007 kB |
| react-dialog Dialog (including children components) |
82.755 kB24.581 kB |
| react-divider Divider |
16.459 kB5.902 kB |
| react-image Image |
10.78 kB4.264 kB |
| react-input Input |
23.757 kB7.704 kB |
| react-label Label |
9.338 kB3.86 kB |
| react-link Link |
11.784 kB4.867 kB |
| react-menu Menu (including children components) |
116.572 kB35.778 kB |
| react-menu Menu (including selectable components) |
119.641 kB36.297 kB |
| react-overflow hooks only |
10.685 kB4.104 kB |
| react-popover Popover |
102.963 kB31.553 kB |
| react-portal Portal |
10.576 kB3.875 kB |
| react-portal-compat PortalCompatProvider |
5.851 kB1.964 kB |
| react-positioning usePositioning |
19.7 kB7.404 kB |
| react-provider FluentProvider |
15.755 kB5.883 kB |
| react-radio Radio |
35.56 kB11.929 kB |
| react-radio RadioGroup |
14.248 kB5.7 kB |
| react-select Select |
20.846 kB7.346 kB |
| react-slider Slider |
31.526 kB10.046 kB |
| react-spinbutton SpinButton |
44.102 kB12.425 kB |
| react-spinner Spinner |
19.977 kB6.438 kB |
| react-switch Switch |
32.097 kB10.27 kB |
| react-text Text - Default |
11.782 kB4.605 kB |
| react-text Text - Wrappers |
15.092 kB5.044 kB |
| react-textarea Textarea |
25.013 kB8.133 kB |
| react-theme Single theme token import |
69 B89 B |
| react-theme Teams: all themes |
29.65 kB6.444 kB |
| react-theme Teams: Light theme |
17.486 kB5.057 kB |
| react-tooltip Tooltip |
41.535 kB14.639 kB |
| react-utilities SSRProvider |
180 B159 B |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 9b578bd041287f8ab317a2f439acd939f1cf8aff:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: 92bc886e6e3e5ec43847752941456666eb69d32b (build)
![size-auditor[bot] avatar](https://avatars.githubusercontent.com/in/13711?v=4 "Published by a pub.dev verified publisher"){kind=small}
Perf Analysis (@fluentui/react-components)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1527 | 1660 | 5000 | |
| Button | mount | 1141 | 1121 | 5000 | |
| FluentProvider | mount | 1953 | 1875 | 5000 | |
| FluentProviderWithTheme | mount | 781 | 794 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 698 | 704 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 761 | 739 | 10 | |
| MakeStyles | mount | 2235 | 2437 | 50000 | |
| SpinButton | mount | 3108 | 2997 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| FlexMinimalPerf.default | 344 | 298 | 1.15:1 |
| AvatarMinimalPerf.default | 224 | 197 | 1.14:1 |
| PortalMinimalPerf.default | 186 | 163 | 1.14:1 |
| BoxMinimalPerf.default | 378 | 338 | 1.12:1 |
| ButtonMinimalPerf.default | 186 | 172 | 1.08:1 |
| ChatWithPopoverPerf.default | 418 | 386 | 1.08:1 |
| SkeletonMinimalPerf.default | 383 | 355 | 1.08:1 |
| CarouselMinimalPerf.default | 515 | 483 | 1.07:1 |
| GridMinimalPerf.default | 365 | 340 | 1.07:1 |
| ItemLayoutMinimalPerf.default | 1326 | 1253 | 1.06:1 |
| ListCommonPerf.default | 698 | 660 | 1.06:1 |
| ListNestedPerf.default | 611 | 578 | 1.06:1 |
| ListWith60ListItems.default | 674 | 633 | 1.06:1 |
| TextMinimalPerf.default | 373 | 351 | 1.06:1 |
| TreeWith60ListItems.default | 169 | 159 | 1.06:1 |
| AlertMinimalPerf.default | 299 | 286 | 1.05:1 |
| DividerMinimalPerf.default | 392 | 373 | 1.05:1 |
| ImageMinimalPerf.default | 442 | 422 | 1.05:1 |
| RadioGroupMinimalPerf.default | 497 | 472 | 1.05:1 |
| ButtonSlotsPerf.default | 603 | 586 | 1.03:1 |
| DialogMinimalPerf.default | 822 | 801 | 1.03:1 |
| MenuMinimalPerf.default | 903 | 879 | 1.03:1 |
| ProviderMinimalPerf.default | 408 | 398 | 1.03:1 |
| IconMinimalPerf.default | 742 | 720 | 1.03:1 |
| TableManyItemsPerf.default | 2118 | 2049 | 1.03:1 |
| ToolbarMinimalPerf.default | 1032 | 1002 | 1.03:1 |
| ChatMinimalPerf.default | 785 | 769 | 1.02:1 |
| DropdownMinimalPerf.default | 2811 | 2755 | 1.02:1 |
| LabelMinimalPerf.default | 397 | 389 | 1.02:1 |
| LoaderMinimalPerf.default | 707 | 693 | 1.02:1 |
| ReactionMinimalPerf.default | 402 | 394 | 1.02:1 |
| StatusMinimalPerf.default | 743 | 728 | 1.02:1 |
| TooltipMinimalPerf.default | 2518 | 2477 | 1.02:1 |
| AttachmentMinimalPerf.default | 172 | 171 | 1.01:1 |
| AttachmentSlotsPerf.default | 1165 | 1159 | 1.01:1 |
| EmbedMinimalPerf.default | 3992 | 3947 | 1.01:1 |
| HeaderSlotsPerf.default | 828 | 820 | 1.01:1 |
| PopupMinimalPerf.default | 665 | 659 | 1.01:1 |
| CheckboxMinimalPerf.default | 2249 | 2250 | 1:1 |
| HeaderMinimalPerf.default | 386 | 387 | 1:1 |
| InputMinimalPerf.default | 1203 | 1207 | 1:1 |
| ListMinimalPerf.default | 564 | 563 | 1:1 |
| RosterPerf.default | 2343 | 2345 | 1:1 |
| ProviderMergeThemesPerf.default | 1296 | 1292 | 1:1 |
| RefMinimalPerf.default | 213 | 214 | 1:1 |
| SplitButtonMinimalPerf.default | 4687 | 4689 | 1:1 |
| TextAreaMinimalPerf.default | 538 | 536 | 1:1 |
| CustomToolbarPrototype.default | 2728 | 2726 | 1:1 |
| AnimationMinimalPerf.default | 549 | 553 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1388 | 1399 | 0.99:1 |
| DatepickerMinimalPerf.default | 6075 | 6142 | 0.99:1 |
| DropdownManyItemsPerf.default | 731 | 736 | 0.99:1 |
| SegmentMinimalPerf.default | 361 | 364 | 0.99:1 |
| VideoMinimalPerf.default | 788 | 795 | 0.99:1 |
| AccordionMinimalPerf.default | 161 | 165 | 0.98:1 |
| MenuButtonMinimalPerf.default | 1832 | 1869 | 0.98:1 |
| TreeMinimalPerf.default | 855 | 869 | 0.98:1 |
| SliderMinimalPerf.default | 1671 | 1717 | 0.97:1 |
| CardMinimalPerf.default | 571 | 595 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 290 | 301 | 0.96:1 |
| TableMinimalPerf.default | 420 | 437 | 0.96:1 |
| FormMinimalPerf.default | 405 | 425 | 0.95:1 |
| LayoutMinimalPerf.default | 364 | 385 | 0.95:1 |
Perf Analysis (@fluentui/react)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1395 | 1488 | 5000 | |
| Breadcrumb | mount | 3559 | 3546 | 1000 | |
| Checkbox | mount | 3107 | 3166 | 5000 | |
| CheckboxBase | mount | 2887 | 2829 | 5000 | |
| ChoiceGroup | mount | 5306 | 5329 | 5000 | |
| ComboBox | mount | 1493 | 1469 | 1000 | |
| CommandBar | mount | 11659 | 11623 | 1000 | |
| ContextualMenu | mount | 14004 | 13745 | 1000 | |
| DefaultButton | mount | 1748 | 1652 | 5000 | |
| DetailsRow | mount | 4315 | 4443 | 5000 | |
| DetailsRowFast | mount | 4398 | 4395 | 5000 | |
| DetailsRowNoStyles | mount | 4173 | 4159 | 5000 | |
| Dialog | mount | 3689 | 3776 | 1000 | |
| DocumentCardTitle | mount | 681 | 715 | 1000 | |
| Dropdown | mount | 3928 | 4005 | 5000 | |
| FocusTrapZone | mount | 2470 | 2441 | 5000 | |
| FocusZone | mount | 2309 | 2348 | 5000 | |
| GroupedList | mount | 62515 | 70972 | 2 | |
| GroupedList | virtual-rerender | 29771 | 29481 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 112297 | 112063 | 2 | |
| GroupedListV2 | mount | 671 | 701 | 2 | |
| GroupedListV2 | virtual-rerender | 657 | 648 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 664 | 718 | 2 | |
| IconButton | mount | 2358 | 2242 | 5000 | |
| Label | mount | 867 | 864 | 5000 | |
| Layer | mount | 5102 | 5146 | 5000 | |
| Link | mount | 977 | 995 | 5000 | |
| MenuButton | mount | 1980 | 2022 | 5000 | |
| MessageBar | mount | 2751 | 2849 | 5000 | |
| Nav | mount | 3969 | 3899 | 1000 | |
| OverflowSet | mount | 1641 | 1661 | 5000 | |
| Panel | mount | 3022 | 3040 | 1000 | |
| Persona | mount | 1498 | 1458 | 1000 | |
| Pivot | mount | 1980 | 1998 | 1000 | |
| PrimaryButton | mount | 1925 | 1845 | 5000 | |
| Rating | mount | 8487 | 8477 | 5000 | |
| SearchBox | mount | 1822 | 1897 | 5000 | |
| Shimmer | mount | 3411 | 3429 | 5000 | |
| Slider | mount | 2507 | 2537 | 5000 | |
| SpinButton | mount | 5536 | 5522 | 5000 | |
| Spinner | mount | 958 | 937 | 5000 | |
| SplitButton | mount | 3788 | 3742 | 5000 | |
| Stack | mount | 1081 | 1017 | 5000 | |
| StackWithIntrinsicChildren | mount | 2779 | 2807 | 5000 | |
| StackWithTextChildren | mount | 5753 | 5750 | 5000 | |
| SwatchColorPicker | mount | 12412 | 13415 | 5000 | |
| TagPicker | mount | 3141 | 3180 | 5000 | |
| TeachingBubble | mount | 105098 | 105620 | 5000 | |
| Text | mount | 987 | 967 | 5000 | |
| TextField | mount | 1941 | 1899 | 5000 | |
| ThemeProvider | mount | 1893 | 1827 | 5000 | |
| ThemeProvider | virtual-rerender | 1295 | 1298 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2648 | 2641 | 5000 | |
| Toggle | mount | 1354 | 1335 | 5000 | |
| buttonNative | mount | 683 | 647 | 5000 |