fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

docs(react-card): remove ASSET_URL export to fix codesandbox examples

Open marcosmoura opened this issue 3 years ago • 4 comments

Current Behavior

By exporting a ASSET_URL, the codesandbox examples were not loading.

New Behavior

Remove export and use a static variable instead

Related Issue(s)

Fixes #24793

marcosmoura avatar Sep 19 '22 13:09 marcosmoura

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64bf295e714f98c08d18e602cdeddbd77cdf2e69:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar Sep 19 '22 14:09 codesandbox-ci[bot]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 48d8c5c16b5367a3dfd295391512984051bbe727 (build)

size-auditor[bot] avatar Sep 19 '22 14:09 size-auditor[bot]

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
67.002 kB
19.261 kB
react-card
Card
62.684 kB
18.177 kB
react-card
CardFooter
8.561 kB
3.601 kB
react-card
CardHeader
9.604 kB
3.94 kB
react-card
CardPreview
8.662 kB
3.656 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.689 kB
52.37 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 48d8c5c16b5367a3dfd295391512984051bbe727

fabricteam avatar Sep 19 '22 14:09 fabricteam

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1324 1314 5000
Button mount 955 953 5000
FluentProvider mount 1588 1589 5000
FluentProviderWithTheme mount 629 637 10
FluentProviderWithTheme virtual-rerender 582 586 10
FluentProviderWithTheme virtual-rerender-with-unmount 629 633 10
MakeStyles mount 1887 1869 50000
SpinButton mount 2595 2521 5000

fabricteam avatar Sep 19 '22 14:09 fabricteam