fluentui
fluentui copied to clipboard
fix(Toolbar): close previous submenu when opening another submenu
Current Behavior
New Behavior
Related Issue(s)
Fixes #24833
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 84e0df1e606c165bfd660fd5a57a2d3731644227:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
| toolbar-submenu-react17 | Issue #24833 |
Asset size changes
| Project | Bundle | Baseline Size | New Size | Difference |
|---|---|---|---|---|
| office-ui-fabric-react | fluentui-react-northstar-Toolbar | 181.355 kB | 181.366 kB |
Over Tolerance (1024 B)
Over Baseline
Below Baseline
New
Removed 1 kB = 1000 B
Baseline commit: 0e50bf23a6604793d0eaa2626c87dbec9cd600d8 (build)
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 124 | 102 | 1.22:1 |
| ChatWithPopoverPerf.default | 310 | 262 | 1.18:1 |
| HeaderSlotsPerf.default | 621 | 537 | 1.16:1 |
| DropdownManyItemsPerf.default | 552 | 484 | 1.14:1 |
| FlexMinimalPerf.default | 230 | 206 | 1.12:1 |
| TreeWith60ListItems.default | 127 | 113 | 1.12:1 |
| AvatarMinimalPerf.default | 160 | 146 | 1.1:1 |
| DropdownMinimalPerf.default | 2177 | 1978 | 1.1:1 |
| TextAreaMinimalPerf.default | 370 | 337 | 1.1:1 |
| SkeletonMinimalPerf.default | 257 | 238 | 1.08:1 |
| ButtonMinimalPerf.default | 123 | 116 | 1.06:1 |
| EmbedMinimalPerf.default | 2798 | 2645 | 1.06:1 |
| LayoutMinimalPerf.default | 262 | 250 | 1.05:1 |
| MenuMinimalPerf.default | 624 | 595 | 1.05:1 |
| RosterPerf.default | 1609 | 1537 | 1.05:1 |
| ReactionMinimalPerf.default | 276 | 263 | 1.05:1 |
| SliderMinimalPerf.default | 1186 | 1133 | 1.05:1 |
| DividerMinimalPerf.default | 256 | 245 | 1.04:1 |
| PortalMinimalPerf.default | 124 | 119 | 1.04:1 |
| TableManyItemsPerf.default | 1472 | 1415 | 1.04:1 |
| AlertMinimalPerf.default | 189 | 183 | 1.03:1 |
| ImageMinimalPerf.default | 273 | 266 | 1.03:1 |
| RefMinimalPerf.default | 157 | 153 | 1.03:1 |
| TextMinimalPerf.default | 247 | 240 | 1.03:1 |
| AccordionMinimalPerf.default | 103 | 101 | 1.02:1 |
| CarouselMinimalPerf.default | 334 | 328 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 194 | 190 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 912 | 893 | 1.02:1 |
| ListWith60ListItems.default | 462 | 455 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1254 | 1234 | 1.02:1 |
| PopupMinimalPerf.default | 462 | 455 | 1.02:1 |
| AttachmentSlotsPerf.default | 808 | 802 | 1.01:1 |
| InputMinimalPerf.default | 834 | 824 | 1.01:1 |
| ListMinimalPerf.default | 368 | 364 | 1.01:1 |
| ProviderMinimalPerf.default | 299 | 295 | 1.01:1 |
| StatusMinimalPerf.default | 491 | 485 | 1.01:1 |
| CustomToolbarPrototype.default | 2000 | 1975 | 1.01:1 |
| ToolbarMinimalPerf.default | 669 | 665 | 1.01:1 |
| GridMinimalPerf.default | 239 | 239 | 1:1 |
| HeaderMinimalPerf.default | 290 | 291 | 1:1 |
| LoaderMinimalPerf.default | 485 | 485 | 1:1 |
| TableMinimalPerf.default | 307 | 306 | 1:1 |
| TreeMinimalPerf.default | 665 | 662 | 1:1 |
| AnimationMinimalPerf.default | 383 | 386 | 0.99:1 |
| CheckboxMinimalPerf.default | 1521 | 1531 | 0.99:1 |
| LabelMinimalPerf.default | 270 | 272 | 0.99:1 |
| ProviderMergeThemesPerf.default | 938 | 949 | 0.99:1 |
| TooltipMinimalPerf.default | 1753 | 1778 | 0.99:1 |
| VideoMinimalPerf.default | 538 | 548 | 0.98:1 |
| ChatMinimalPerf.default | 531 | 546 | 0.97:1 |
| DatepickerMinimalPerf.default | 4246 | 4359 | 0.97:1 |
| ButtonOverridesMissPerf.default | 959 | 999 | 0.96:1 |
| SplitButtonMinimalPerf.default | 3243 | 3369 | 0.96:1 |
| IconMinimalPerf.default | 500 | 522 | 0.96:1 |
| SegmentMinimalPerf.default | 255 | 269 | 0.95:1 |
| CardMinimalPerf.default | 376 | 398 | 0.94:1 |
| ButtonSlotsPerf.default | 388 | 416 | 0.93:1 |
| FormMinimalPerf.default | 278 | 300 | 0.93:1 |
| ListCommonPerf.default | 445 | 477 | 0.93:1 |
| DialogMinimalPerf.default | 562 | 622 | 0.9:1 |
| RadioGroupMinimalPerf.default | 313 | 350 | 0.89:1 |
| BoxMinimalPerf.default | 236 | 269 | 0.88:1 |
| ListNestedPerf.default | 391 | 444 | 0.88:1 |