fluentui
fluentui copied to clipboard
fix: Combobox text attribute ignored when empty string is passed
Current Behavior
ComboBox Component: When using text property empty string is ignored, meaning you can't clear the ComboBox freeform value
New Behavior
Empty string is not ignored and you are able to use text property to clear ComboBox freeform value
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 314e6bb3aeed7f108a3edefdafa1c41b8888d68d:
Sandbox | Source |
---|---|
@fluentui/react 8 starter | Configuration |
@fluentui/react-components 9 starter | Configuration |
Asset size changes
Project | Bundle | Baseline Size | New Size | Difference |
---|---|---|---|---|
office-ui-fabric-react | fluentui-react-ComboBox | 236.76 kB | 236.77 kB | |
office-ui-fabric-react | fluentui-react-TimePicker | 225.769 kB | 225.779 kB |
Over Tolerance (1024 B)
Over Baseline
Below Baseline
New
Removed 1 kB = 1000 B
Baseline commit: fe895d6bb4f9df0304f63f7e77acafef4b912925 (build)
Perf Analysis (@fluentui/react
)
No significant results to display.
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 1197 | 1190 | 5000 | |
Breadcrumb | mount | 2784 | 2811 | 1000 | |
Checkbox | mount | 2624 | 2625 | 5000 | |
CheckboxBase | mount | 2363 | 2368 | 5000 | |
ChoiceGroup | mount | 4239 | 4281 | 5000 | |
ComboBox | mount | 1170 | 1185 | 1000 | |
CommandBar | mount | 9200 | 9304 | 1000 | |
ContextualMenu | mount | 10122 | 10083 | 1000 | |
DefaultButton | mount | 1372 | 1349 | 5000 | |
DetailsRow | mount | 3358 | 3363 | 5000 | |
DetailsRowFast | mount | 3371 | 3368 | 5000 | |
DetailsRowNoStyles | mount | 3247 | 3201 | 5000 | |
Dialog | mount | 2952 | 2978 | 1000 | |
DocumentCardTitle | mount | 590 | 570 | 1000 | |
Dropdown | mount | 3146 | 3138 | 5000 | |
FocusTrapZone | mount | 1952 | 1947 | 5000 | |
FocusZone | mount | 1926 | 1926 | 5000 | |
GroupedList | mount | 48321 | 54133 | 2 | |
GroupedList | virtual-rerender | 22928 | 23156 | 2 | |
GroupedList | virtual-rerender-with-unmount | 82196 | 82994 | 2 | |
GroupedListV2 | mount | 559 | 548 | 2 | |
GroupedListV2 | virtual-rerender | 533 | 528 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 556 | 566 | 2 | |
IconButton | mount | 1796 | 1786 | 5000 | |
Label | mount | 744 | 752 | 5000 | |
Layer | mount | 4158 | 4093 | 5000 | |
Link | mount | 871 | 849 | 5000 | |
MenuButton | mount | 1609 | 1603 | 5000 | |
MessageBar | mount | 2383 | 2351 | 5000 | |
Nav | mount | 3046 | 3039 | 1000 | |
OverflowSet | mount | 1385 | 1412 | 5000 | |
Panel | mount | 2485 | 2504 | 1000 | |
Persona | mount | 1241 | 1257 | 1000 | |
Pivot | mount | 1520 | 1534 | 1000 | |
PrimaryButton | mount | 1478 | 1462 | 5000 | |
Rating | mount | 7016 | 7010 | 5000 | |
SearchBox | mount | 1483 | 1495 | 5000 | |
Shimmer | mount | 2913 | 2894 | 5000 | |
Slider | mount | 2116 | 2117 | 5000 | |
SpinButton | mount | 4252 | 4297 | 5000 | |
Spinner | mount | 825 | 834 | 5000 | |
SplitButton | mount | 2794 | 2832 | 5000 | |
Stack | mount | 856 | 853 | 5000 | |
StackWithIntrinsicChildren | mount | 2219 | 2166 | 5000 | |
StackWithTextChildren | mount | 4898 | 4879 | 5000 | |
SwatchColorPicker | mount | 9511 | 9436 | 5000 | |
TagPicker | mount | 2350 | 2466 | 5000 | |
TeachingBubble | mount | 74713 | 74120 | 5000 | |
Text | mount | 828 | 821 | 5000 | |
TextField | mount | 1544 | 1559 | 5000 | |
ThemeProvider | mount | 1446 | 1453 | 5000 | |
ThemeProvider | virtual-rerender | 1130 | 1133 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2010 | 1998 | 5000 | |
Toggle | mount | 1132 | 1138 | 5000 | |
buttonNative | mount | 526 | 535 | 5000 |
@smhigley Hello, could I please request merge of this commit?
Going to force merge this as it's getting hung up on northstar and v9 screener jobs.