fluentui
fluentui copied to clipboard
chore(migrate-converged): Update generator to move stories to root of package
Changes
- removes old
moveStoriesfunction which was used to move stories fromsrc/storiestosrc/stories/{ComponentName}since that entire migration is now complete. moveStoriesToPackageRootfunction will move existing stories fromsrc/storiesto/stories. Any new components created with thecreate-componentscript will now have their story templates populated in the/stories/{ComponentName}directory.moveDocsToSubfoldermoves existingMIGRATION.mdandSPEC.mdfiles to the/docsfolder.- Updates
npm.ignorefile to ignore/docsand/storiessubfolders.
Demo:
https://user-images.githubusercontent.com/8649804/186023193-304409f4-e22e-4cff-860c-2da61607b284.mp4
Part of #24129
📊 Bundle size report
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| global-context createContext |
533 B341 B |
| global-context createContextSelector |
554 B348 B |
| priority-overflow createOverflowManager |
2.936 kB1.212 kB |
| react-accordion Accordion (including children components) |
79.037 kB24.059 kB |
| react-alert Alert |
84.117 kB21.07 kB |
| react-avatar Avatar |
48.828 kB13.842 kB |
| react-avatar AvatarGroup |
14.95 kB5.989 kB |
| react-avatar AvatarGroupItem |
68.796 kB19.182 kB |
| react-badge Badge |
22.6 kB7.205 kB |
| react-badge CounterBadge |
23.49 kB7.489 kB |
| react-badge PresenceBadge |
24.05 kB7.067 kB |
| react-button Button |
36.278 kB9.636 kB |
| react-button CompoundButton |
43.303 kB10.852 kB |
| react-button MenuButton |
38.972 kB10.536 kB |
| react-button SplitButton |
46.418 kB11.916 kB |
| react-button ToggleButton |
52.145 kB11.108 kB |
| react-card Card - All |
67.17 kB19.281 kB |
| react-card Card |
62.852 kB18.198 kB |
| react-card CardFooter |
8.561 kB3.601 kB |
| react-card CardHeader |
9.604 kB3.94 kB |
| react-card CardPreview |
8.662 kB3.656 kB |
| react-combobox Combobox (including child components) |
74.642 kB24.19 kB |
| react-combobox Dropdown (including child components) |
74.242 kB24.089 kB |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
188.815 kB52.287 kB |
| react-components react-components: FluentProvider & webLightTheme |
33.4 kB11.008 kB |
| react-dialog Dialog (including children components) |
82.465 kB24.447 kB |
| react-divider Divider |
16.459 kB5.902 kB |
| react-image Image |
10.78 kB4.264 kB |
| react-input Input |
23.762 kB7.706 kB |
| react-label Label |
9.338 kB3.86 kB |
| react-link Link |
11.806 kB4.868 kB |
| react-menu Menu (including children components) |
116.558 kB35.725 kB |
| react-menu Menu (including selectable components) |
119.627 kB36.246 kB |
| react-overflow hooks only |
10.685 kB4.104 kB |
| react-persona Persona |
53.946 kB15.225 kB |
| react-popover Popover |
102.756 kB31.5 kB |
| react-portal Portal |
10.582 kB3.875 kB |
| react-portal-compat PortalCompatProvider |
5.857 kB1.978 kB |
| react-positioning usePositioning |
19.7 kB7.404 kB |
| react-progress Progress |
13.44 kB5.247 kB |
| react-provider FluentProvider |
15.761 kB5.885 kB |
| react-radio Radio |
36.39 kB12.103 kB |
| react-radio RadioGroup |
14.248 kB5.7 kB |
| react-select Select |
20.846 kB7.346 kB |
| react-slider Slider |
31.759 kB10.064 kB |
| react-spinbutton SpinButton |
44.102 kB12.425 kB |
| react-spinner Spinner |
19.977 kB6.438 kB |
| react-switch Switch |
33.342 kB10.557 kB |
| react-text Text - Default |
11.782 kB4.605 kB |
| react-text Text - Wrappers |
15.092 kB5.044 kB |
| react-textarea Textarea |
25.018 kB8.133 kB |
| react-theme Single theme token import |
69 B89 B |
| react-theme Teams: all themes |
29.65 kB6.444 kB |
| react-theme Teams: Light theme |
17.486 kB5.057 kB |
| react-tooltip Tooltip |
41.566 kB14.644 kB |
| react-utilities SSRProvider |
180 B159 B |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 5d001f0dd3d5fadf337880f0f7dc7ccc8d6711da:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: 93f154ac2821be1fd408fa98943a641f9d3dc464 (build)
Perf Analysis (@fluentui/react-components)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1683 | 1633 | 5000 | |
| Button | mount | 1113 | 1164 | 5000 | |
| FluentProvider | mount | 1958 | 1926 | 5000 | |
| FluentProviderWithTheme | mount | 700 | 723 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 652 | 671 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 712 | 714 | 10 | |
| MakeStyles | mount | 2269 | 2255 | 50000 | |
| SpinButton | mount | 3240 | 3247 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 196 | 176 | 1.11:1 |
| CardMinimalPerf.default | 611 | 555 | 1.1:1 |
| FlexMinimalPerf.default | 315 | 287 | 1.1:1 |
| AttachmentMinimalPerf.default | 180 | 170 | 1.06:1 |
| ButtonSlotsPerf.default | 615 | 579 | 1.06:1 |
| GridMinimalPerf.default | 373 | 352 | 1.06:1 |
| ItemLayoutMinimalPerf.default | 1323 | 1246 | 1.06:1 |
| RefMinimalPerf.default | 230 | 218 | 1.06:1 |
| FormMinimalPerf.default | 430 | 409 | 1.05:1 |
| RadioGroupMinimalPerf.default | 509 | 487 | 1.05:1 |
| TreeWith60ListItems.default | 179 | 170 | 1.05:1 |
| ChatMinimalPerf.default | 802 | 771 | 1.04:1 |
| EmbedMinimalPerf.default | 4062 | 3916 | 1.04:1 |
| ImageMinimalPerf.default | 435 | 420 | 1.04:1 |
| SliderMinimalPerf.default | 1847 | 1773 | 1.04:1 |
| AnimationMinimalPerf.default | 577 | 561 | 1.03:1 |
| ButtonMinimalPerf.default | 179 | 174 | 1.03:1 |
| HeaderMinimalPerf.default | 391 | 378 | 1.03:1 |
| ListMinimalPerf.default | 559 | 545 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1867 | 1817 | 1.03:1 |
| TableMinimalPerf.default | 449 | 434 | 1.03:1 |
| BoxMinimalPerf.default | 364 | 357 | 1.02:1 |
| DialogMinimalPerf.default | 826 | 808 | 1.02:1 |
| DropdownMinimalPerf.default | 2904 | 2837 | 1.02:1 |
| ListNestedPerf.default | 626 | 615 | 1.02:1 |
| SegmentMinimalPerf.default | 379 | 370 | 1.02:1 |
| CheckboxMinimalPerf.default | 2268 | 2253 | 1.01:1 |
| DatepickerMinimalPerf.default | 6260 | 6195 | 1.01:1 |
| ListWith60ListItems.default | 671 | 665 | 1.01:1 |
| MenuMinimalPerf.default | 901 | 889 | 1.01:1 |
| ProviderMinimalPerf.default | 412 | 409 | 1.01:1 |
| ReactionMinimalPerf.default | 404 | 400 | 1.01:1 |
| SkeletonMinimalPerf.default | 372 | 367 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4827 | 4772 | 1.01:1 |
| TextMinimalPerf.default | 379 | 377 | 1.01:1 |
| TextAreaMinimalPerf.default | 546 | 538 | 1.01:1 |
| ToolbarMinimalPerf.default | 1020 | 1008 | 1.01:1 |
| TooltipMinimalPerf.default | 2550 | 2526 | 1.01:1 |
| AvatarMinimalPerf.default | 196 | 196 | 1:1 |
| CarouselMinimalPerf.default | 519 | 518 | 1:1 |
| ChatWithPopoverPerf.default | 429 | 430 | 1:1 |
| HeaderSlotsPerf.default | 846 | 850 | 1:1 |
| TreeMinimalPerf.default | 874 | 874 | 1:1 |
| AttachmentSlotsPerf.default | 1199 | 1210 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 310 | 314 | 0.99:1 |
| DividerMinimalPerf.default | 380 | 382 | 0.99:1 |
| InputMinimalPerf.default | 1197 | 1215 | 0.99:1 |
| LoaderMinimalPerf.default | 701 | 705 | 0.99:1 |
| PopupMinimalPerf.default | 664 | 674 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1262 | 1280 | 0.99:1 |
| CustomToolbarPrototype.default | 2744 | 2771 | 0.99:1 |
| DropdownManyItemsPerf.default | 739 | 751 | 0.98:1 |
| StatusMinimalPerf.default | 714 | 731 | 0.98:1 |
| TableManyItemsPerf.default | 2091 | 2142 | 0.98:1 |
| LayoutMinimalPerf.default | 373 | 383 | 0.97:1 |
| ListCommonPerf.default | 695 | 717 | 0.97:1 |
| RosterPerf.default | 2337 | 2404 | 0.97:1 |
| IconMinimalPerf.default | 693 | 714 | 0.97:1 |
| VideoMinimalPerf.default | 798 | 825 | 0.97:1 |
| AlertMinimalPerf.default | 285 | 298 | 0.96:1 |
| LabelMinimalPerf.default | 403 | 421 | 0.96:1 |
| ButtonOverridesMissPerf.default | 1423 | 1491 | 0.95:1 |
| AccordionMinimalPerf.default | 162 | 175 | 0.93:1 |
Perf Analysis (@fluentui/react)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1559 | 1567 | 5000 | |
| Breadcrumb | mount | 3600 | 3628 | 1000 | |
| Checkbox | mount | 3391 | 3380 | 5000 | |
| CheckboxBase | mount | 3033 | 3035 | 5000 | |
| ChoiceGroup | mount | 5785 | 5847 | 5000 | |
| ComboBox | mount | 1556 | 1604 | 1000 | |
| CommandBar | mount | 11771 | 11768 | 1000 | |
| ContextualMenu | mount | 13299 | 13236 | 1000 | |
| DefaultButton | mount | 1804 | 1804 | 5000 | |
| DetailsRow | mount | 4662 | 4697 | 5000 | |
| DetailsRowFast | mount | 4667 | 4635 | 5000 | |
| DetailsRowNoStyles | mount | 4440 | 4493 | 5000 | |
| Dialog | mount | 3840 | 3874 | 1000 | |
| DocumentCardTitle | mount | 735 | 732 | 1000 | |
| Dropdown | mount | 4210 | 4206 | 5000 | |
| FocusTrapZone | mount | 2478 | 2524 | 5000 | |
| FocusZone | mount | 2447 | 2445 | 5000 | |
| GroupedList | mount | 68846 | 80166 | 2 | |
| GroupedList | virtual-rerender | 32956 | 32776 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 110051 | 111476 | 2 | |
| GroupedListV2 | mount | 708 | 692 | 2 | |
| GroupedListV2 | virtual-rerender | 654 | 648 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 686 | 688 | 2 | |
| IconButton | mount | 2462 | 2521 | 5000 | |
| Label | mount | 874 | 876 | 5000 | |
| Layer | mount | 5348 | 5357 | 5000 | |
| Link | mount | 1037 | 1074 | 5000 | |
| MenuButton | mount | 2194 | 2197 | 5000 | |
| MessageBar | mount | 2858 | 2838 | 5000 | |
| Nav | mount | 4188 | 4266 | 1000 | |
| OverflowSet | mount | 1684 | 1720 | 5000 | |
| Panel | mount | 3103 | 3123 | 1000 | |
| Persona | mount | 1643 | 1629 | 1000 | |
| Pivot | mount | 2054 | 2100 | 1000 | |
| PrimaryButton | mount | 1932 | 1937 | 5000 | |
| Rating | mount | 9340 | 9379 | 5000 | |
| SearchBox | mount | 1972 | 1971 | 5000 | |
| Shimmer | mount | 3605 | 3730 | 5000 | |
| Slider | mount | 2663 | 2614 | 5000 | |
| SpinButton | mount | 5987 | 6062 | 5000 | |
| Spinner | mount | 975 | 1013 | 5000 | |
| SplitButton | mount | 3977 | 3929 | 5000 | |
| Stack | mount | 1101 | 1092 | 5000 | |
| StackWithIntrinsicChildren | mount | 3235 | 3330 | 5000 | |
| StackWithTextChildren | mount | 6611 | 6534 | 5000 | |
| SwatchColorPicker | mount | 13379 | 13516 | 5000 | |
| TagPicker | mount | 3374 | 3386 | 5000 | |
| TeachingBubble | mount | 105350 | 104755 | 5000 | |
| Text | mount | 1020 | 1018 | 5000 | |
| TextField | mount | 2064 | 2051 | 5000 | |
| ThemeProvider | mount | 1905 | 1934 | 5000 | |
| ThemeProvider | virtual-rerender | 1325 | 1362 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2699 | 2703 | 5000 | |
| Toggle | mount | 1409 | 1395 | 5000 | |
| buttonNative | mount | 681 | 678 | 5000 |