fluentui
fluentui copied to clipboard
fix(docsite): add build time script to fix the website title from Web…
Current Behavior
The current website default title is "Webpack App":
There is currently no option in Storybook to add a custom title, as the last comment in this issue specifies.
New Behavior
The current fix involves running a script after the build-storybook
command finishes running which changes the <title>
tag value to the desired one.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a30d14a615367eaeccb1822d073ed0940b3c89ce:
Sandbox | Source |
---|---|
@fluentui/react 8 starter | Configuration |
@fluentui/react-components 9 starter | Configuration |
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: e6cf183695d6d67a24e038c49a876224e5ed35e5 (build)
if we modify the manager-head.html
page like here does that mean all pages will have that title or are they still overriden when the user navigates ?
if we modify the
manager-head.html
page like here does that mean all pages will have that title or are they still overriden when the user navigates ?
That will work on client side, but for places where you post the url and have the metadata fetched (like Outlook) it won't unfortunately.
if we modify the
manager-head.html
page like here does that mean all pages will have that title or are they still overriden when the user navigates ?
it's about initial load @ling1726 , until js kicks in the static title is displayed....
ship.it !