fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Fix check:affected-package scoping

Open ralucapelin opened this issue 3 years ago • 5 comments

Current Behavior

check:affected-package was using workspaces that included components not tested by the screener, so sometimes a stoybook build would be created even though there was no need for it.

New Behavior

check:affected-package is using the appropriate workspace for each screener so that the scoped building is correct.

Related Issue(s)

Fixes #

ralucapelin avatar Aug 10 '22 11:08 ralucapelin

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 84017b6464e13c46a7ae8c61875ead2ff4b6965b (build)

size-auditor[bot] avatar Aug 10 '22 11:08 size-auditor[bot]

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1213 1229 5000
Button mount 930 960 5000
FluentProvider mount 1477 1469 5000
FluentProviderWithTheme mount 579 577 10
FluentProviderWithTheme virtual-rerender 538 539 10
FluentProviderWithTheme virtual-rerender-with-unmount 570 568 10
MakeStyles mount 1991 1996 50000
SpinButton mount 2288 2283 5000

fabricteam avatar Aug 10 '22 11:08 fabricteam

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.485 kB
24.082 kB
react-alert
Alert
82.763 kB
20.582 kB
react-avatar
Avatar
48.172 kB
13.615 kB
react-avatar
AvatarGroup
13.43 kB
5.382 kB
react-avatar
AvatarGroupItem
64.878 kB
18.284 kB
react-badge
Badge
22.494 kB
7.157 kB
react-badge
CounterBadge
23.397 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.396 kB
9.575 kB
react-button
CompoundButton
43.469 kB
10.812 kB
react-button
MenuButton
39.014 kB
10.456 kB
react-button
SplitButton
46.506 kB
11.827 kB
react-button
ToggleButton
51.91 kB
11.003 kB
react-card
Card - All
67.42 kB
19.249 kB
react-card
Card
63.102 kB
18.167 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
71.331 kB
23.323 kB
react-combobox
Dropdown (including child components)
70.459 kB
23.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.604 kB
51.784 kB
react-components
react-components: FluentProvider & webLightTheme
32.688 kB
10.736 kB
react-dialog
Dialog (including children components)
85.064 kB
25.293 kB
react-divider
Divider
16.321 kB
5.837 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.554 kB
7.644 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.197 kB
4.912 kB
react-menu
Menu (including children components)
114.702 kB
35.037 kB
react-menu
Menu (including selectable components)
117.901 kB
35.533 kB
react-overflow
hooks only
10.839 kB
4.146 kB
react-popover
Popover
102.042 kB
31.308 kB
react-portal
Portal
10.49 kB
3.845 kB
react-positioning
usePositioning
19.656 kB
7.388 kB
react-provider
FluentProvider
15.565 kB
5.818 kB
react-radio
Radio
36.13 kB
11.947 kB
react-radio
RadioGroup
14.319 kB
5.711 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
31.988 kB
10.019 kB
react-spinbutton
SpinButton
43.899 kB
12.362 kB
react-spinner
Spinner
19.932 kB
6.363 kB
react-switch
Switch
32.438 kB
10.218 kB
react-text
Text - Default
11.572 kB
4.537 kB
react-text
Text - Wrappers
14.882 kB
4.977 kB
react-textarea
Textarea
23.674 kB
7.83 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
28.995 kB
6.215 kB
react-theme
Teams: Light theme
16.973 kB
4.86 kB
react-tooltip
Tooltip
41.307 kB
14.586 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against 84017b6464e13c46a7ae8c61875ead2ff4b6965b

fabricteam avatar Aug 10 '22 12:08 fabricteam

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 379 338 1.12:1
TextMinimalPerf.default 367 331 1.11:1
AvatarMinimalPerf.default 196 184 1.07:1
ImageMinimalPerf.default 391 366 1.07:1
BoxMinimalPerf.default 330 312 1.06:1
ButtonMinimalPerf.default 165 155 1.06:1
FormMinimalPerf.default 417 392 1.06:1
SegmentMinimalPerf.default 347 331 1.05:1
SkeletonMinimalPerf.default 355 338 1.05:1
AnimationMinimalPerf.default 542 521 1.04:1
CardMinimalPerf.default 555 533 1.04:1
ChatDuplicateMessagesPerf.default 305 292 1.04:1
ChatWithPopoverPerf.default 391 375 1.04:1
ProviderMinimalPerf.default 407 391 1.04:1
IconMinimalPerf.default 607 585 1.04:1
RadioGroupMinimalPerf.default 450 439 1.03:1
TableManyItemsPerf.default 1974 1916 1.03:1
TextAreaMinimalPerf.default 482 469 1.03:1
ButtonSlotsPerf.default 550 537 1.02:1
DividerMinimalPerf.default 361 353 1.02:1
DropdownMinimalPerf.default 3244 3182 1.02:1
EmbedMinimalPerf.default 4221 4151 1.02:1
GridMinimalPerf.default 324 318 1.02:1
HeaderSlotsPerf.default 765 751 1.02:1
ItemLayoutMinimalPerf.default 1205 1187 1.02:1
LabelMinimalPerf.default 393 385 1.02:1
MenuMinimalPerf.default 854 841 1.02:1
AlertMinimalPerf.default 262 259 1.01:1
DatepickerMinimalPerf.default 6115 6033 1.01:1
FlexMinimalPerf.default 286 283 1.01:1
InputMinimalPerf.default 1330 1313 1.01:1
ListNestedPerf.default 581 573 1.01:1
ProviderMergeThemesPerf.default 1300 1282 1.01:1
TableMinimalPerf.default 388 383 1.01:1
ToolbarMinimalPerf.default 957 948 1.01:1
VideoMinimalPerf.default 624 616 1.01:1
AttachmentSlotsPerf.default 1115 1112 1:1
CarouselMinimalPerf.default 465 463 1:1
LoaderMinimalPerf.default 702 700 1:1
MenuButtonMinimalPerf.default 1707 1713 1:1
SliderMinimalPerf.default 1693 1689 1:1
ButtonOverridesMissPerf.default 1498 1520 0.99:1
CheckboxMinimalPerf.default 2698 2723 0.99:1
DialogMinimalPerf.default 815 821 0.99:1
DropdownManyItemsPerf.default 675 682 0.99:1
PopupMinimalPerf.default 626 633 0.99:1
SplitButtonMinimalPerf.default 4393 4423 0.99:1
StatusMinimalPerf.default 663 668 0.99:1
CustomToolbarPrototype.default 2774 2802 0.99:1
TooltipMinimalPerf.default 1114 1124 0.99:1
TreeMinimalPerf.default 821 828 0.99:1
ChatMinimalPerf.default 736 751 0.98:1
ListCommonPerf.default 634 649 0.98:1
RosterPerf.default 1116 1139 0.98:1
PortalMinimalPerf.default 168 171 0.98:1
ReactionMinimalPerf.default 383 390 0.98:1
RefMinimalPerf.default 217 221 0.98:1
AttachmentMinimalPerf.default 142 146 0.97:1
ListMinimalPerf.default 505 519 0.97:1
AccordionMinimalPerf.default 147 153 0.96:1
LayoutMinimalPerf.default 338 353 0.96:1
TreeWith60ListItems.default 155 164 0.95:1
ListWith60ListItems.default 562 613 0.92:1

fabricteam avatar Aug 10 '22 12:08 fabricteam

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 791 781 5000
Breadcrumb mount 2371 2403 1000
Checkbox mount 2257 2248 5000
CheckboxBase mount 1975 1973 5000
ChoiceGroup mount 4076 4045 5000
ComboBox mount 846 871 1000
CommandBar mount 9188 9175 1000
ContextualMenu mount 10330 10407 1000
DefaultButton mount 973 984 5000
DetailsRow mount 3331 3293 5000
DetailsRowFast mount 3303 3318 5000
DetailsRowNoStyles mount 3192 3231 5000
Dialog mount 2475 2485 1000
DocumentCardTitle mount 156 163 1000
Dropdown mount 3064 2858 5000
FocusTrapZone mount 1652 1639 5000
FocusZone mount 1531 1545 5000
IconButton mount 1496 1512 5000
Label mount 338 309 5000
Layer mount 2679 2741 5000
Link mount 418 410 5000
MenuButton mount 1276 1309 5000
MessageBar mount 1844 1877 5000
Nav mount 2897 2852 1000
OverflowSet mount 953 937 5000
Panel mount 1893 1895 1000
Persona mount 876 880 1000
Pivot mount 1267 1244 1000
PrimaryButton mount 1148 1128 5000
Rating mount 6760 6642 5000
SearchBox mount 1135 1136 5000
Shimmer mount 2147 2172 5000
Slider mount 1689 1655 5000
SpinButton mount 4336 4377 5000
Spinner mount 375 373 5000
SplitButton mount 2766 2739 5000
Stack mount 440 456 5000
StackWithIntrinsicChildren mount 1992 1977 5000
StackWithTextChildren mount 4479 4513 5000
SwatchColorPicker mount 10078 10117 5000
TagPicker mount 2333 2345 5000
TeachingBubble mount 81800 82844 5000
Text mount 369 375 5000
TextField mount 1195 1213 5000
ThemeProvider mount 1042 1048 5000
ThemeProvider virtual-rerender 593 585 5000
ThemeProvider virtual-rerender-with-unmount 1538 1551 5000
Toggle mount 689 685 5000
buttonNative mount 111 115 5000

fabricteam avatar Aug 10 '22 12:08 fabricteam