fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

chore: fix no-context-default-value lint violations for cxe

Open ling1726 opened this issue 3 years ago • 4 comments

Fixes #21338

ling1726 avatar Aug 08 '22 17:08 ling1726

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
79.485 kB
24.082 kB
79.516 kB
24.107 kB
31 B
25 B
react-avatar
AvatarGroup
15.068 kB
6.016 kB
15.072 kB
6.016 kB
4 B
react-avatar
AvatarGroupItem
68.333 kB
19.018 kB
68.362 kB
19.042 kB
29 B
24 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.673 kB
51.804 kB
188.691 kB
51.848 kB
18 B
44 B
react-radio
Radio
36.13 kB
11.947 kB
36.15 kB
11.966 kB
20 B
19 B
react-radio
RadioGroup
14.319 kB
5.711 kB
14.323 kB
5.711 kB
4 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
82.771 kB
20.584 kB
react-avatar
Avatar
48.18 kB
13.616 kB
react-components
react-components: FluentProvider & webLightTheme
32.786 kB
10.759 kB
🤖 This report was generated against 84e2b1a8b1e8d2e9008297b6c35c76231ae3a31c

fabricteam avatar Aug 08 '22 17:08 fabricteam

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 512bac00c62e37f919bb9c33be73661339f5a1b9 (build)

size-auditor[bot] avatar Aug 08 '22 17:08 size-auditor[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit defccf9421a21d1e25fc9aab879f7ede33c1398a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar Aug 09 '22 06:08 codesandbox-ci[bot]

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1230 1230 5000
Button mount 936 934 5000
FluentProvider mount 1470 1467 5000
FluentProviderWithTheme mount 583 583 10
FluentProviderWithTheme virtual-rerender 544 540 10
FluentProviderWithTheme virtual-rerender-with-unmount 568 577 10
MakeStyles mount 1996 2002 50000
SpinButton mount 2303 2285 5000

fabricteam avatar Aug 09 '22 06:08 fabricteam

@micahgodbolt @GeoffCox is it possible to get a review on this ?

ling1726 avatar Aug 11 '22 12:08 ling1726