fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

feat: Add accessibility scenarios for Fluent UI v9 components #3

Open adamsamec opened this issue 3 years ago • 6 comments

Description of changes

This PR adds accessibility scenarios for testing of the Checkbox, Input, RadioGroup, Spinner, Switch, TabList and Textarea Fluent UI v9 components using a screen reader, and modifies the scenarios for some other existing components mainly so that they use Fluent UI components instead of native HTML elements. The list of scenarios for testing can be found here.

adamsamec avatar May 31 '22 15:05 adamsamec

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03005ed20b654c9d683ccc12ab0a5170fab4d2fa:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

codesandbox-ci[bot] avatar May 31 '22 15:05 codesandbox-ci[bot]

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 9dd5a3b5f20bb1a1fe2c4961c262201a691f460d

fabricteam avatar May 31 '22 15:05 fabricteam

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9dd5a3b5f20bb1a1fe2c4961c262201a691f460d (build)

size-auditor[bot] avatar May 31 '22 15:05 size-auditor[bot]

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1265 1324 5000
Button mount 936 949 5000
FluentProvider mount 1560 1521 5000
FluentProviderWithTheme mount 627 556 10
FluentProviderWithTheme virtual-rerender 593 521 10
FluentProviderWithTheme virtual-rerender-with-unmount 625 646 10
MakeStyles mount 1893 1878 50000
SpinButton mount 2504 2432 5000

fabricteam avatar May 31 '22 15:05 fabricteam

@adamsamec , should we merge this PR? it's been approved for a while now.

bsunderhus avatar Jul 21 '22 11:07 bsunderhus

Please, don't merge it yet. It's still work in progress.

adamsamec avatar Jul 22 '22 14:07 adamsamec