fluentui-system-icons icon indicating copy to clipboard operation
fluentui-system-icons copied to clipboard

Is the direction of regular icon of "Text Number List" wrong?

Open liangdrime opened this issue 1 year ago • 0 comments

Summary

  • Outlook for Mac is using ic_fluent_text_number_list_20_regular in many scenarios, and the released version used in Outlook is 1.1.221.

  • This icon displays normal in LTR language. number-list-ltr

  • Then it is mirrored in RTL language, but the number "1,2,3" was flipped that seems not as expected. And we do not provide versions for languages like Arabic. number-list-rtl

Potential cause

  • In the metadata.json of Text Number List of the latest version 1.1.222, the directionType is unique and the singleton is LTR. Looks like this will result in a single language-direction icon for number list.
  • After looking into the Content.json of ic_fluent_text_number_list_20_regular which generated in iOS/FluentIcon/Assets/IconAssets.xcassets path, we're providing only one version of language-direction for this icon. So that Xcode can only use this icon and its mirror. image

Question/Expected

  • Is this as by design or a bug?
  • Do we need to provide various kinds of icon for LTR/RTL languages, just like what Apple does in SF Symbols? image

Cc @nickromano

liangdrime avatar Nov 07 '23 06:11 liangdrime

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

:x: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: d-light / attributes-correctness
  • :heavy_check_mark: guangzhou/tiptop-stage-6-x-500mw-moving-head-laser-11ch.xml
  • :x: guangzhou/tiptop-stage-6-x-500mw-moving-head-laser-23ch.xmlError parsing XML: Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/PAN
:heavy_check_mark: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: dmxcontrol3 / channel-numbers
  • :heavy_check_mark: guangzhou-tiptop-stage-6-x-500mw-moving-head-laser-11ch.xml
  • :heavy_check_mark: guangzhou-tiptop-stage-6-x-500mw-moving-head-laser-23ch.xml
:heavy_check_mark: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: dragonframe / json-schema-conformity
  • :heavy_check_mark: guangzhou/tiptop-stage-6-x-500mw-moving-head-laser.json
  • :heavy_check_mark: manufacturers.json
:heavy_check_mark: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: millumin / json-schema-conformity
  • :heavy_check_mark: guangzhou/tiptop-stage-6-x-500mw-moving-head-laser.json
:heavy_check_mark: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: qlcplus_4.12.2 / fixture-tool-validation
  • :heavy_check_mark: fixtures/Guangzhou-Tiptop-Stage-6-x-500mW-Moving-Head-Laser.qxf
:heavy_check_mark: guangzhou / tiptop-stage-6-x-500mw-moving-head-laser: qlcplus_4.12.2 / xsd-schema-conformity
  • :heavy_check_mark: fixtures/Guangzhou-Tiptop-Stage-6-x-500mW-Moving-Head-Laser.qxf

github-actions[bot] avatar Jan 11 '24 16:01 github-actions[bot]