fluentui-blazor
fluentui-blazor copied to clipboard
microsoft
fix: rows attribute in all textArea controls
🐛 Bug Report
None of the text-area controls; fast-text-area, fluent-text-area, FluentTextArea honor the rows attribute.
💻 Repro or Code Sample
Use your own code or try the online version here: https://explore.fast.design/components/fast-text-area. Change the value of the row attribute to anything you like.
🤔 Expected Behavior
The size of the TextArea changes in response to the value of the rows attribute.
😯 Current Behavior
Absolutely nothing.
🔦 Context
Trying to set up a text area to hold the response containing a large amount of text from a rest call. Unless, until this gets fixed I'll have to try CSS styles (hopefully it will work).
🌍 Your Environment
Windows 10 Pro x64 All Browsers; Firefox, Chrome, Vivaldi, Brave, Edge. .Net 5, Microsoft.Fast.Components.FluentUI 0.3.0 JetBrains Rider 2021.2 Microsoft Visual Studio 2019 Pro. Blazor Server
@chrisdholt This seems like a bug in the underlying web components. How do you want to handle tracking this?
Can this be fixed now @vnbaaij given the closed PR? https://github.com/microsoft/fast/issues/3869 https://github.com/microsoft/fast/pull/5856
@vnbaaij Given that this issue has been open a long time: Could we add the possibility to override html textarea CSS and therefore enable the fix mentioned below with height:auto?
https://github.com/microsoft/fluentui/issues/27842
I actually committed a PR to the Fluent Web Components (https://github.com/microsoft/fluentui/pull/28135) to fix it there by implementing the same fix as in https://github.com/microsoft/fast/pull/5856. Hope to get that merged in in web-component script soon (it is already approved).
A workaround was asked for in #417, a duplicate of this issue. See the following: https://github.com/microsoft/fluentui-blazor/issues/417#issuecomment-1602965916
This has (finally!) been fixed with Fluent UI Web Components release 2.5.16. The new web-components.min.js file will be included in the next minor version (2.4.2) which we will release tomorrow.
@vnbaaij Tested this now and there still seems to be some error. You can see that it does not work in the examples either:
https://www.fluentui-blazor.net/TextArea#rows-and-cols
Unfortunately I think this has to be reopened.
It does work in 3.0.0-RC.1:
https://calm-sea-053fa6a03-365.westeurope.3.azurestaticapps.net/TextArea#rowsandcols
We are having an issue with the library not picking up the latest version of the script. Need to investigate what is happening. No 2.4.2 package because of that. Might take a while because of summer vacation.