fluentui-blazor icon indicating copy to clipboard operation
fluentui-blazor copied to clipboard

[InfoButton] New component

Open franklupo opened this issue 1 year ago • 4 comments

Use Info button control to provide additional information to users.

React: https://react.fluentui.dev/?path=/docs/components-infolabel--default

Power Apps:: https://learn.microsoft.com/en-us/power-apps/maker/canvas-apps/controls/modern-controls/modern-control-info-button

image

image

franklupo avatar Jul 05 '24 13:07 franklupo

Hi! Is the InfoButton still planned for a upcoming release? Got a use case for it, so just checking before i implement my own version :P

PascalVorwerk avatar Oct 21 '24 07:10 PascalVorwerk

Hi! Is the InfoButton still planned for a upcoming release? Got a use case for it, so just checking before i implement my own version :P

@franklupo is quite busy it seems.

What if you just take the code from this PR, address the remarks Denis and I posted and submit a new PR? We'll then review that one and include it in an upcoming version (all dependent on time we all need) if all is okay. Probably still less work than creating a new one yourself and as a bonus you'd be helping us and the community. Sounds good?

vnbaaij avatar Oct 21 '24 08:10 vnbaaij

Hi! Is the InfoButton still planned for a upcoming release? Got a use case for it, so just checking before i implement my own version :P

@franklupo is quite busy it seems.

What if you just take the code from this PR, address the remarks Denis and I posted and submit a new PR? We'll then review that one and include it in an upcoming version (all dependent on time we all need) if all is okay. Probably still less work than creating a new one yourself and as a bonus you'd be helping us and the community. Sounds good?

Hey! I have to check whether I can invest time in that, depending on how much its needed right now. But I will keep it in mind!

PascalVorwerk avatar Oct 21 '24 10:10 PascalVorwerk

Hi guys, Sorry, but this is not a good time for me. Can you handle it @vnbaaij ? Thanks

franklupo avatar Oct 21 '24 12:10 franklupo

Hey, I just did some work on the unit tests that were still needed. Was there any other work still open in this PR? It's a pretty long log so I'm not sure.

I tried to open up a PR but I am getting a unauthorized response, do I need to get some rights in order to open it? Storing the changes locally now :)

PascalVorwerk avatar Oct 25 '24 21:10 PascalVorwerk

You need to create a PR in your fork of our repo. It should work then.

Once you're done, we need to go through all earlier unresolved comments and check those.

vnbaaij avatar Oct 28 '24 12:10 vnbaaij

Closing this as there has been no activity for a while.

vnbaaij avatar Nov 19 '24 08:11 vnbaaij