fluentui-blazor icon indicating copy to clipboard operation
fluentui-blazor copied to clipboard

Add MultiSelect to FluentDataGrid

Open chigivigi opened this issue 2 years ago • 5 comments

🙋 Feature Request

MultiSelect in FluentDataGrid would send multiple rows of data for bulk actions. Running the same action one row at a time would take a lot of time.

🤔 Expected Behavior

A user should be able to select multiple rows or deselect a selected row and be able to save the selected rows in a list that can be passed inside a method for bulk operation.

😯 Current Behavior

Currently you can only select one row, when you select another row, the previous row is no longer selected, and the data cannot be used anymore.

🔦 Context

I am migrating an existing application from the old blazor fluent nugget package to Blazor fast. I have a few grids that have a lot of rows. The rows are passed to a function that executes actions based on information that is passed from the row. A lot of rows need to be passed every day and every action needs sometimes to finish. It is better to pass multiple rows so that the action can run multiple times without the user needing to initiate it for every row and check if the previous row action is completed.

chigivigi avatar Mar 31 '22 09:03 chigivigi

Official row selection including multiple row selection is in development now. I saw a demo of it yesterday myself, including full keyboard support. 😄

EisenbergEffect avatar Apr 06 '22 18:04 EisenbergEffect

Will it be part of the new nugget version? When will it be released?

chigivigi avatar Apr 08 '22 14:04 chigivigi

The PR for selection in foundation is under review here: https://github.com/microsoft/fast/pull/5786 Once that is merged in, the Fluent UI Web Components will be updated, and then the Blazor wrappers.

@vnbaaij Can you review the PR to make sure there's a path to enable this quickly for Blazor? I'm not sure if we'll need to do special interop or if it will "just work".

EisenbergEffect avatar Apr 08 '22 14:04 EisenbergEffect

The PR for selection in foundation is under review here: microsoft/fast#5786 Once that is merged in, the Fluent UI Web Components will be updated, and then the Blazor wrappers.

@vnbaaij Can you review the PR to make sure there's a path to enable this quickly for Blazor? I'm not sure if we'll need to do special interop or if it will "just work".

It is merged in! 😍

LuohuaRain avatar Mar 24 '23 12:03 LuohuaRain

Yes, it is merged in, but....this is done in the main branch which targets a vNext version. The FAST team needs to port it to the archive-v1 branch so it will still take some time for it to land in our version and we can pick it up on the Blazor side. Besides, since then we moved to using QuickGrid as the 'engine' of the grid. We are still rendering the web components but we need to look at how it works together.

vnbaaij avatar Mar 24 '23 13:03 vnbaaij

When will it be officially released?

Seanxwy avatar Apr 10 '24 02:04 Seanxwy

You'd need to ask in the Fluent UI Web Components repo when this will be in their script..

vnbaaij avatar Apr 10 '24 05:04 vnbaaij

since 2023 we are waiting for this 🤦‍♂️

sardar97 avatar Apr 26 '24 01:04 sardar97

since 2023 we are waiting for this 🤦‍♂️

Seanxwy avatar Apr 26 '24 08:04 Seanxwy

Come on guys...bit of a lame reaction. There are more important things in the world than just a bit of software.

You can go ask in the Fluent UI repo about the status but my guess is this won't come to the v2 (which we are using) version anymore...

vnbaaij avatar Apr 26 '24 12:04 vnbaaij

but @vnbaaij this is very very important Feature! we love Blazor we love Fluent UI we want to improve it and use it instead of other components and you need you to support it so please be kind with issues and Feature requests 🙏

sardar97 avatar Apr 26 '24 12:04 sardar97

if I create a pull request to add MultiSelect for FluentDataGrid with Branch shall I use?

sardar97 avatar Apr 26 '24 12:04 sardar97

Well, we don't really need to do anything. This is 'just an open source project that we are maintaining (with love) as good as we can. It is not a funded Microsoft product for which you can open a support ticket.

I don't think it is fair to say we are not open to requests and unkind to issues. We're pretty responsive I believe. And sometimes 'no' is also an answer 😉.

If you wanttthis feature, make it know to where it needs tocome from, ie the web components. It helps if other people beside us are more vocal there.

vnbaaij avatar Apr 26 '24 12:04 vnbaaij

if I create a pull request to add MultiSelect for FluentDataGrid with Branch shall I use?

We always work on the dev branch. main is where we merge to to build the release packages.

vnbaaij avatar Apr 26 '24 12:04 vnbaaij

hahaha ok i will try a pull request ❤️😅

sardar97 avatar Apr 26 '24 12:04 sardar97

@sardar97 I've started a similar work in PR #1952. Do you have any other ideas or requests?

dvoituron avatar Apr 26 '24 12:04 dvoituron

oh! Nice one @dvoituron I haven't seen that! so I will write my suggestion at there comments for you. thank u

sardar97 avatar Apr 26 '24 16:04 sardar97