fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

Activity Indicator Demo: Dynamic start/stop activity button title

Open imthath-m opened this issue 1 year ago • 0 comments

Platforms Impacted

  • [ ] iOS
  • [ ] macOS

Description of changes

Updated title of action button in the settings of ActivityIndicator demo page. The title is now dynamic and changes based on the state of the activity indicators below.

In the iOS demo app, open ActivityIndicator. The button in the second section (Settings) will now read "Stop Activity". If you tap that, the activity indicators below will stop spinning (and also hide if that is enabled) and the button title will change to "Start Activity".

Previously the button was named "Start/Stop Activity" which did not exactly represent the state of the activity indicators below.

Binary change

No change in binary size as the change is only in the iOS demo app.

Verification

  • The button title is "Stop Activity" when activity indicators are running
  • The button title is "Start Activity" when activity indicators are stopped/hidden
Visual Verification

Before

https://github.com/microsoft/fluentui-apple/assets/46041492/8e0185f1-a1f6-4d29-a4d6-21b9e33a5a5f

After

https://github.com/microsoft/fluentui-apple/assets/46041492/6b964386-bc99-4462-a494-3462e9b02f7e

Pull request checklist

This PR has considered:

  • [ ] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

imthath-m avatar Jan 26 '24 12:01 imthath-m