fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

Improve iOS contributing guide

Open imthath-m opened this issue 1 year ago • 6 comments

Platforms Impacted

  • [ ] iOS
  • [ ] macOS

Description of changes

Improve spelling and grammar in iOS contributing guide

Binary change

No impact in binary

Verification

No testing is required

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • [ ] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [ ] SwiftUI consumption (validation or new demo scenarios needed)
  • [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

imthath-m avatar Jan 24 '24 04:01 imthath-m

@laminesm Thanks for checking.

Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

imthath-m avatar Jan 30 '24 06:01 imthath-m

@laminesm Thanks for checking.

Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

I'm not sure what workflow you're referring to. Everything seems to be in order for this PR though all that's left is to merge it. I can do that for you if you don't have that option.

laminesm avatar Jan 30 '24 22:01 laminesm

@laminesm Nevermind. Last time I checked some workflows were pending. Now its all done.

Kindly go ahead and merge it as I don't have access.

imthath-m avatar Jan 31 '24 00:01 imthath-m

Sorry for the delay--looks like your branch will need to be updated. Once that's done, I will complete the merge.

mischreiber avatar Jan 31 '24 23:01 mischreiber

No worries.

Rebase done.

imthath-m avatar Feb 01 '24 06:02 imthath-m

@mischreiber Auto merging now disabled because I rebased latest changes. So this is now at awaiting approval again. CleanShot 2024-02-02 at 16 44 00@2x

imthath-m avatar Feb 02 '24 11:02 imthath-m