fluentui-apple
fluentui-apple copied to clipboard
Improve iOS contributing guide
Platforms Impacted
- [ ] iOS
- [ ] macOS
Description of changes
Improve spelling and grammar in iOS contributing guide
Binary change
No impact in binary
Verification
No testing is required
Visual Verification
Before | After |
---|---|
Screenshot or description before this change | Screenshot or description with this change |
Pull request checklist
This PR has considered:
- [ ] Light and Dark appearances
- [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
- [ ] VoiceOver and Keyboard Accessibility
- [ ] Internationalization and Right to Left layouts
- [ ] Different resolutions (1x, 2x, 3x)
- [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
- [ ] iPad Pointer interaction
- [ ] SwiftUI consumption (validation or new demo scenarios needed)
- [ ] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow
@laminesm Thanks for checking.
Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?
@laminesm Thanks for checking.
Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?
I'm not sure what workflow you're referring to. Everything seems to be in order for this PR though all that's left is to merge it. I can do that for you if you don't have that option.
@laminesm Nevermind. Last time I checked some workflows were pending. Now its all done.
Kindly go ahead and merge it as I don't have access.
Sorry for the delay--looks like your branch will need to be updated. Once that's done, I will complete the merge.
No worries.
Rebase done.
@mischreiber Auto merging now disabled because I rebased latest changes. So this is now at awaiting approval again.