fluentui-apple icon indicating copy to clipboard operation
fluentui-apple copied to clipboard

Update Notification to make default action optional

Open huwilkes opened this issue 2 years ago • 0 comments

Platforms Impacted

  • [x] iOS
  • [ ] macOS

Description of changes

The UIKit notification had a default action by default, so I added that back in to the SwiftUI one, but now we want that to be optional. Also cleaned up additional bools left in the style.

Verification

Before After
Notification_DefaultDismiss_Before Notification_DefaultDismiss_After2

Pull request checklist

This PR has considered:

  • [ ] Light and Dark appearances
  • [ ] iOS supported versions (all major versions greater than or equal current target deployment version)
  • [ ] VoiceOver and Keyboard Accessibility
  • [ ] Internationalization and Right to Left layouts
  • [ ] Different resolutions (1x, 2x, 3x)
  • [ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • [ ] iPad Pointer interaction
  • [x] SwiftUI consumption (validation or new demo scenarios needed)
  • [x] Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

huwilkes avatar Aug 11 '22 17:08 huwilkes