finops-toolkit icon indicating copy to clipboard operation
finops-toolkit copied to clipboard

Private endpoint support for Hub 0.4

Open arthurclares opened this issue 1 year ago • 0 comments

🛠️ Description

This PR updates the Private Endpoint branch and add the code to support private endpoints on Hub 0.4

Deploy the Template

Run the following command to deploy the template:

New-AzResourceGroupDeployment -TemplateFile <FileLocation> -ResourceGroupName <ResourceGroupName> -Location <AzureLocation> -NetworkingOption "<NetworkingOption>" -HubName <HubName>

Replace <FileLocation> with the path to your template file.

Replace <ResourceGroupName> with the name of your resource group created in the previous step.

Replace <AzureLocation> with the desired Azure region.

Replace <NetworkingOption> with one of the options described below.

Replace <HubName> with the desired name for your Hub.

Example:

New-AzResourceGroupDeployment -TemplateFile .\main.bicep -ResourceGroupName HubsPrivateEndpoint-Location swedencentral -NetworkingOption "Private" -HubName finopshubs

The networking parameter accepts the following values:

Networking Parameter Description
Public Deploys Hubs with a public endpoint.
Private Creates a new Virtual Network within the resource group and manages all the endpoint configuration for you.
Existing Allows you to use an existing Virtual Network.

This PR does not update the change log nor the deployment guide. These will come on a later PR.

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • [ ] 🤏 Lint tests
  • [ ] 🤞 PS -WhatIf / az validate
  • [x] 👍 Manually deployed + verified
  • [ ] 💪 Unit tests
  • [ ] 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • [ ] 🚨 This is a breaking change.
  • [ ] 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • [ ] ✅ Updated changelog (required for dev PRs)
  • [x] ➡️ Will add log in a future PR (feature branch PRs only)
  • [ ] ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • [ ] ✅ Public docs in docs (required for dev)
  • [ ] ✅ Internal dev docs in src (required for dev)
  • [x] ➡️ Will add docs in a future PR (feature branch PRs only)
  • [ ] ❎ Docs not needed (small/internal change)

arthurclares avatar Aug 23 '24 15:08 arthurclares