finops-toolkit icon indicating copy to clipboard operation
finops-toolkit copied to clipboard

Commitment Discounts PowerBI report - problem with Cost Management connector MCA

Open MS-mikeo opened this issue 1 year ago • 1 comments

🐛 Problem

When connecting an MCA customer to the Cost Management connector piece of the Commitment Discounts PowerBI report, there are errors for the RecommendationsSingle table (normalizedSize column) and RecommendationsShared table (recommendedQuantityNormalized column) saying that the columns are not found.

👣 Repro steps

Connect an MCA customer to the Cost Management connector piece of the Commitment Discounts PowerBI report.

🤔 Expected

Populate the tables so that recommendations tabs work in the PowerBI report.

📷 Screenshots

Initial issue (data was populating those columns): image

image

image

After trying to update queries from steps mentioned in similar issue (https://github.com/microsoft/finops-toolkit/issues/493#issuecomment-1926416386):

image

image

MS-mikeo avatar May 14 '24 20:05 MS-mikeo

@flanakin Wondering if this issue is related to this comment: https://github.com/microsoft/finops-toolkit/issues/604#issuecomment-1973168293 #604

arthurclares avatar May 20 '24 19:05 arthurclares

@arthurclares Agreed. That's what it sounds like.

@MS-mikeo What version of the Power BI report is this? (You can find the version on the first tab.) We fixed this once, so it should be resolved in the latest version. Do you still see this if you download the latest reports?

flanakin avatar May 25 '24 17:05 flanakin

@flanakin - Here is the feedback from the customer as of Friday 5/24.

"I downloaded the committed discounts powerbi report again. the recommendations are still empty. I used the billing account and billing profile for the scope.

I also noticed that for reservation I don't get a list or on-demand cost which is needed to calculate the actual savings. It doesn't matter whether I look at the commitments, savings, prices, or chargeback tab. I don't have a way to calculate the actual savings for the RI, only the savings plan. This is what I wanted to see to be able to show managment how much we are saving with the RIs vs the savings plan."

MS-mikeo avatar May 27 '24 21:05 MS-mikeo

I am also getting the same errors, and tried to connect to either with MCA or CMC

Expression.Error: The column 'normalizedSize' of the table wasn't found. Details: normalizedSize

Expression.Error: The column 'recommendedQuantityNormalized' of the table wasn't found. Details: recommendedQuantityNormalized

saleemmy avatar May 30 '24 19:05 saleemmy

I'll add this to the next release so we can try to get it resolved. It should be quick.

flanakin avatar Jun 05 '24 07:06 flanakin

Just to document that we saw this today as well for an MCA. image

CaddyG avatar Jun 19 '24 14:06 CaddyG

Turns out this was fixed in the Cost Management connector report, but not the Commitment discounts report. I just submitted PR #766 to fix this. Feel free to check out the changes and add any comments, if you're familiar with Power Query M language 🙂 We always love extra reviewers! We'll probably close this quickly, but if anyone has any comments, we can address them separately.

flanakin avatar Jun 24 '24 17:06 flanakin