fast icon indicating copy to clipboard operation
fast copied to clipboard

fix(fast-element-1): some template bindings not properly being marked as volatile

Open m-akinc opened this issue 1 year ago • 0 comments

🐛 Bug Report

Some bindings that should be marked as volatile are not, so changes may not be properly detected.

  1. While there is code to detect some conditionals in binding expressions, it does not trigger on ??. This means a binding expression such as x => x.foo ?? x.bar might miss changes to bar.
  2. Aggregate bindings are never marked as volatile due to a bug in the logic. The HTMLBindingDirective constructor tests the stringified binding function for volatility, rather than the parsed parts of the aggregate expression.

💻 Repro or Code Sample

The following binding expressions will not reliably detect changes:

  • my-attr="${x => x.foo ?? x.bar} because nullish coalescing does not match the regex
  • my-attr="foo ${x => x.bar && x.baz} because aggregate bindings are never marked volatile
  • my-attr="foo ${x => x.bar || x.baz} because aggregate bindings are never marked volatile

🤔 Expected Behavior

Attributes should always be updated when a value in the binding expression changes.

😯 Current Behavior

Attributes are not always updated when a value in the binding expression changes.

💁 Possible Solution

🔦 Context

Discovered during resolution of https://github.com/ni/nimble/pull/1839

m-akinc avatar May 21 '24 20:05 m-akinc