fast icon indicating copy to clipboard operation
fast copied to clipboard

Upgrade Playwright to 1.41

Open radium-v opened this issue 1 year ago • 0 comments

Pull Request

📖 Description

In FAST Foundation:

  • Upgrades @playwright/test in fast-foundation and fast-ssr to the latest stable version.
  • Removes custom hasAttribute and toHaveBooleanAttribute assertions from fast-foundation tests.
  • Removes the projects field from the playwright config in fast-foundation (see #6876).
  • Marks flaky tests with test.fixme to skip them for now (these will be addressed in future PRs).

In FAST SSR:

  • Upgrades @playwright/test to the latest stable version.
  • Replaces shadowroot attributes with shadowrootmode in the fast-styles test fixture. See https://chromestatus.com/feature/6239658726391808

👩‍💻 Reviewer Notes

This is a subset of the work planned in #6876, which was doing way more stuff than one PR should be doing.

📑 Test Plan

All tests for all packages should pass. Tests in fast-foundation are no longer run in Chromium three times over.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [x] I have added tests for my changes.
  • [x] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Once Playwright is updated, I can start separating the tests in fast-foundation to run them in async mode. Then, we can get tests running properly in Firefox and Webkit.

radium-v avatar Feb 12 '24 04:02 radium-v