fast icon indicating copy to clipboard operation
fast copied to clipboard

Add `tslib` to the nohoist list

Open radium-v opened this issue 1 year ago • 0 comments

Pull Request

📖 Description

This PR adds tslib to the nohoist list in the root-level package.json. Additionally, it adds tslib as a dependency to both fast-router and fast-react-wrapper (it was previously only a transient dependency).

🎫 Issues

Due to this problem in tslib, tslib is locked to version 2.5.0 in fast-ssr.

👩‍💻 Reviewer Notes

For both fast-router and fast-react-wrapper, I marked tslib as a dependency since "importHelpers": true is set in their tsconfigs.

I wasn't sure if all packages should be locked to 2.5.0, since fast-ssr is the only one that uses a class private field.

📑 Test Plan

All packages should build and pass all tests as expected.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Once we upgrade to TypeScript 5+, we should be able to continue using more recent versions of tslib.

radium-v avatar Feb 02 '24 20:02 radium-v