fast icon indicating copy to clipboard operation
fast copied to clipboard

Fix: Missing syntax highlighting for css partials

Open rizwan3d opened this issue 2 years ago • 3 comments

Pull Request

📖 Description

Missing syntax highlighting for CSS partials in FAST tagged templates extension.

🎫 Issues

Regex only has CSS for consideration for template. fix: Missing syntax highlighting for css partials in FAST tagged templates extension #6380

✅ Checklist

General

  • [ ] I have included a change request file using $ yarn change
  • [X] I have added tests for my changes.
  • [X] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [ ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

rizwan3d avatar Nov 16 '23 10:11 rizwan3d

@microsoft-github-policy-service agree

rizwan3d avatar Nov 16 '23 10:11 rizwan3d

I think since css.partial allows for just property lists (instead of selectors followed by property lists), this may need some more work to function properly. There aren't many uses of css.partial in the monorepo but here's one from a test:

const partial = css.partial`color: ${new myDirective}`;

This pattern would need to be defined on its own so it can include the weirdly named source.css#rule-list-innards pattern.

radium-v avatar Nov 17 '23 01:11 radium-v

This needs to be held since the vscode-css package can either handle key-value pairs, or selectors, but not both at the same time.

microsoft/vscode-css#9

radium-v avatar Nov 17 '23 22:11 radium-v

Closing this PR as stale and obsolete with the migration of the package to @radium-v, see #6964.

janechu avatar May 22 '24 15:05 janechu