fast icon indicating copy to clipboard operation
fast copied to clipboard

unmatched div tag in menu-item.template.ts

Open oldoldman opened this issue 2 years ago • 6 comments

Hi guys, I've double checked that </div> at this line has no matching start tag. Many thanks!!!

oldoldman avatar Sep 23 '23 02:09 oldoldman

@chrisdholt @bheston could this be addressed as a part of the ongoing template updates or should we get a fix in sooner?

KingOfTac avatar Sep 27 '23 17:09 KingOfTac

Hello, I would like to work on this issue

kamalrohra avatar Oct 04 '23 15:10 kamalrohra

Hello, I would like to work on this issue

You're more than welcome to take this. I have gone ahead and assigned this to you.

KingOfTac avatar Oct 04 '23 18:10 KingOfTac

@KingOfTac Hi, it seems he's not working on this issue as he's taking so much time for a pretty easy fix. should i work on this?

rahul0x00 avatar Oct 07 '23 09:10 rahul0x00

Hey I have made the required changes just creating a pr wasn't well for a couple of days sorry for the delay

kamalrohra avatar Oct 07 '23 09:10 kamalrohra

Agreed we should get this in aside from the larger template update. I've commented on the PR.

bheston avatar Oct 07 '23 16:10 bheston

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955. I see this was mentioned in a PR, we will be addressing open PRs and merging what we can before we snap an archive branch to preserve the latest state of Foundation, however to bring us up to date I am closing out issues.

janechu avatar May 29 '24 20:05 janechu