fast icon indicating copy to clipboard operation
fast copied to clipboard

Foundation: Update Slider templates

Open bheston opened this issue 2 years ago • 0 comments

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and updates the Slider and Slider Label templates.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Slider

  • 💔 Rename “track-container” part to “track”
  • Add "thumb" class and part wrapper for "thumb" slot
  • 💔 Remove duplicate class (orientation) on root template element

Slider

Slider label

  • 💔 Flatten “container” and “root”
  • 💔 Rename “label” to “content”
  • Add part to "mark" and "content"

Slider label

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [x] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

bheston avatar Aug 08 '23 16:08 bheston