fast icon indicating copy to clipboard operation
fast copied to clipboard

Foundation: Update Progress templates

Open bheston opened this issue 2 years ago • 0 comments

Pull Request

📖 Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and updates the Progress and Progress Ring templates.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. 💔 = potentially style-breaking.

Progress

  • 💔 Rename "progress" container to "determinate" and "indeterminate"
  • 💔 Change “determinate” div to slot
  • 💔 Remove “indeterminateIndicator2” option

Progress

Progress ring

  • 💔 Follow Progress structure

Progress ring

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

📑 Test Plan

Tested via comparison against proposal and in Storybook.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [x] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

bheston avatar Aug 08 '23 01:08 bheston