fast icon indicating copy to clipboard operation
fast copied to clipboard

Foundation: Update Accordion template element naming

Open bheston opened this issue 2 years ago โ€ข 0 comments

Pull Request

๐Ÿ“– Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from #6286 and applies to Accordion and Accordion Item.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. ๐Ÿ’” = potentially style-breaking.

Accordion

  • Remove unused <template> wrapper

Accordion

Accordion item

  • ๐Ÿ’” Rename โ€œiconโ€ to โ€œexpand-collapse-iconโ€
  • ๐Ÿ’” Move โ€œstartโ€ before โ€œbuttonโ€
  • ๐Ÿ’” Rename "region" class and part to "panel"

Accordion item

๐Ÿ‘ฉโ€๐Ÿ’ป Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

๐Ÿ“‘ Test Plan

Tested via comparison against proposal and in Storybook.

โœ… Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [x] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

bheston avatar Aug 07 '23 22:08 bheston