fast icon indicating copy to clipboard operation
fast copied to clipboard

Fix svg imports path resolution for stories

Open radium-v opened this issue 2 years ago • 2 comments

Pull Request

📖 Description

Fixes the squiggles for SVG paths in *.register.ts and *.stories.ts files.

👩‍💻 Reviewer Notes

It seems that combining the PlaywrightTest namespace extension with the "*.svg" module declaration caused the latter to not be picked up, which caused synthetic paths to SVGs to be seen as errors. Splitting global.d.ts into two separate modules fixes this minor inconvenience.

📑 Test Plan

This change should not affect any build or test process.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

radium-v avatar May 22 '23 22:05 radium-v

@microsoft-github-policy-service agree

radium-v avatar May 22 '23 22:05 radium-v

boink

usrrname avatar Jun 29 '23 23:06 usrrname

Closing this, due to #6951 we are only putting in fixes or critical features.

janechu avatar Jun 10 '24 21:06 janechu