fast icon indicating copy to clipboard operation
fast copied to clipboard

fix(foundation): remove readonly from Slider

Open olaf-k opened this issue 2 years ago • 2 comments

📖 Description

This PR removes the readonly state for the Slider component in an effort to keep it close to the input range's behavior. The specs for the latter can be found here (see the 'Bookkeeping details' part after the examples). image

See PR #6438 for a similar update to the radio button.

👩‍💻 Reviewer Notes

As it is a removal, the change is pretty straightforward. Code/tests/doc should be covered. slider-label should not be affected as far as I can tell.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [x] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

olaf-k avatar Oct 28 '22 11:10 olaf-k

@microsoft-github-policy-service agree company="Vonage"

olaf-k avatar Oct 28 '22 11:10 olaf-k

hey team! do you think it'd be possible to push this forward to complete our great ReadOnly Purge? 😁

olaf-k avatar Mar 24 '23 15:03 olaf-k