fast icon indicating copy to clipboard operation
fast copied to clipboard

chore: update to [email protected]

Open nicholasrice opened this issue 2 years ago • 3 comments

Pull Request

📖 Description

Updates to [email protected] across the project. This will allow us to use the latest TypeScript language features, including the override keyword and labeled tuple elements.

🎫 Issues

👩‍💻 Reviewer Notes

I've only directly edited the projects package.json files. All changes to .ts files are a result of running prettier against the project.

This should wait for #6286 to go in so @bheston doesn't have to resolve conflicts for automated changes.

📑 Test Plan

✅ Checklist

General

  • [ ] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [ ] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [ ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

nicholasrice avatar Sep 06 '22 21:09 nicholasrice

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for Validate Benchmarks

github-actions[bot] avatar Sep 06 '22 21:09 github-actions[bot]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-sand-03fe10e10-6359.centralus.azurestaticapps.net

github-actions[bot] avatar Sep 06 '22 22:09 github-actions[bot]

I think this is going to cause a huge set of merge conflicts between Brian's foundation PR and my context PR. Maybe we should wait on this until those are merged?

And...just saw your note on exactly this. Doh.

EisenbergEffect avatar Sep 06 '22 23:09 EisenbergEffect

I just noticed this was still out pending the foundation PR. While I've broken a few pieces off of that, it's still going to be a large change set, but I think it's almost ready pending one more PR merged and then rebased.

How about we unblock this (from my PR perspective) and I can just manually update the foundation package.json and run prettier locally before I rebase once this has gone in. I'm not sure if the PR Rob was working on is merged yet or not.

bheston avatar Jan 22 '23 05:01 bheston