microsoft
enable strictPropertyInitialization in fast-element
Pull Request
📖 Description
This PR enables strictPropertyInitialization in fast-element
🎫 Issues
Part of https://github.com/microsoft/fast/issues/5337
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
- [x] I have included a change request file using
$ yarn change - [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the CONTRIBUTING documentation and followed the standards for this project.
Component-specific
- [ ] I have added a new component
- [ ] I have modified an existing component
- [ ] I have updated the definition file
- [ ] I have updated the configuration file
⏭ Next Steps
Thanks for working on this @m4thieulavoie . I need to think about this a bit. I'm not concerned about the spec file changes. But the changes to the templating engine implementation could have some consequences. I would like the property to be defined, but not sure whether they should be set to undefined or string/etc values. I wonder what if any perf implication or memory implication there is for that given that lots of these things get created, especially at startup time. Some of the code is just to satisfy TS and I want to be careful about that. Because, for example, in the render directive, we know that there will be a template that can create a view by the time the create API is called. So, there's no real reason to check that except to make TS happy.
@m4thieulavoie We just had a big merge last week to FE2. I think we're done with that level of changes. There are more things coming up late next week and the following week. Do you want to take one more go at updating this and let's see if we can merge next week? I apologize for the churn.
@m4thieulavoie We just had a big merge last week to FE2. I think we're done with that level of changes. There are more things coming up late next week and the following week. Do you want to take one more go at updating this and let's see if we can merge next week? I apologize for the churn.
Yeah sure. I guess I'm confused on the direction to take after reading https://github.com/microsoft/fast/pull/6297#issuecomment-1227578106 , hence me pausing that work 👍 Let me know!
Ooops. I should read my own comments again before posting. Sorry! Let me do another review, and get you some concrete feedback. No need to take any action until I deliver this. Ball in my court.
I believe this PR is too out of date at this point and we're considering FE 2 to be ready for production release. Let's swing back around after launch if we still want to add strictPropertyInitialization, sorry this got pushed back and delayed for so long there were a lot of moving pieces at the time this was posted.
