fast icon indicating copy to clipboard operation
fast copied to clipboard

docs: fix data grid custom columns sample in component explorer

Open izaxon opened this issue 3 years ago • 1 comments

🙋 Documentation Request

The custom columns sample of the data grid doesn't seem to work. Cell content go missing when switching between custom columns. image

It may be that the problem is in the data grid component.

How to repeat:

  1. Go to https://explore.fast.design/components/fast-data-grid
  2. Select Custom components in the dropdown: image
  3. Click the Three columns button: image
  4. The first two columns lack values in their cells.

💁 Possible Solution

izaxon avatar Jul 04 '22 05:07 izaxon

Thanks for reporting this @izaxon ! @scomea Any idea whether this is an issue with the grid itself or something in the explorer?

EisenbergEffect avatar Jul 06 '22 18:07 EisenbergEffect

@EisenbergEffect This is an issue with the grid itself. Here is a cleaner example: https://codepen.io/yonatankra/pen/vYredxP?editors=1111 It also happens locally for me.

YonatanKra avatar Nov 17 '22 13:11 YonatanKra

Thanks for the update @YonatanKra !

EisenbergEffect avatar Nov 17 '22 13:11 EisenbergEffect

There looks to be an issue with swapping in a new array instance for columnDefinitions vs mutating the existing array. This variation of the example works as expected - https://codepen.io/scomea/pen/poKWYJp?editors=1111 Ideally the grid should tolerate a swap as well, so I'll look into it.

scomea avatar Nov 17 '22 14:11 scomea