fast icon indicating copy to clipboard operation
fast copied to clipboard

feat: add data grid row selection

Open scomea opened this issue 3 years ago • 4 comments

📖 Description

Data grid currently does not have any notion of selection built-in, this change adds that functionality for row selection.

image

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [x] I have added tests for my changes.
  • [x] I have tested my changes.
  • [x] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

Add cell selection.

scomea avatar Mar 30 '22 21:03 scomea

@scomea Ready for more reviews?

EisenbergEffect avatar Apr 19 '22 19:04 EisenbergEffect

@scomea Ready for more reviews?

Yes, please.

scomea avatar Apr 19 '22 19:04 scomea

Revised the "unselectable rows" api to be a callback fn rather than an array, seems more flexible.

scomea avatar Aug 05 '22 11:08 scomea

@scomea There were some breaking changes in fast-element which required me to update the grid. Apologies if this messes up your selection work! Let me know if you have any questions otherwise I'll just wait for a ping from you to review this PR once it's updated to latest. Thanks!

EisenbergEffect avatar Sep 16 '22 02:09 EisenbergEffect

Looking forward to this feature!!!

LuohuaRain avatar Nov 08 '22 14:11 LuohuaRain

It would be great if select would be done by "left column" checkbox. Like this, it is not possible to select the column if the cell value is a href link to something.

hkusulja avatar Nov 14 '22 07:11 hkusulja

It would be great if select would be done by "left column" checkbox. Like this, it is not possible to select the column if the cell value is a href link to something.

That's what the disable-click-select attribute is for. When that is true the row will not auto select on click and an author could wire up a custom cell with a checkbox wired up to the row's selected state. I'll see about adding a story for that.

scomea avatar Nov 14 '22 07:11 scomea

Cannot wait to apply this amazing feature!😍😍😍

LuohuaRain avatar Dec 07 '22 12:12 LuohuaRain