fast icon indicating copy to clipboard operation
fast copied to clipboard

feat: use tabbable shadow dom support

Open scomea opened this issue 3 years ago • 3 comments

📖 Description

This pr updates the dialog and toolbar elements to use tabbable's new shadom dom support.

🎫 Issues

Removes some local code.

👩‍💻 Reviewer Notes

📑 Test Plan

  • todo: add some shadow dom tests for dialog/toolbar, ideally in play wright.

✅ Checklist

General

  • [x] I have included a change request file using $ yarn change
  • [ ] I have added tests for my changes.
  • [x] I have tested my changes.
  • [ ] I have updated the project documentation to reflect my changes.
  • [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

scomea avatar Feb 16 '22 15:02 scomea

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 15:04 stale[bot]

FYI, tabbable v5.3.0 and focus-trap v6.8.0 with Shadow DOM support have been published to NPM. I hope it helps for this!

stefcameron avatar Apr 20 '22 23:04 stefcameron

@scomea let's get this up to date, I'd like to see if we can get this in for the final versions of fast-components.

chrisdholt avatar Apr 27 '22 20:04 chrisdholt