fast icon indicating copy to clipboard operation
fast copied to clipboard

fix: vertical mode in slider in the @microsoft/fast-components package

Open janechu opened this issue 4 years ago • 3 comments

🐛 Bug Report

For LTR languages I would expect that slider would place the minimum value at the bottom of the range and the maximum value at the top. This appears to be inverted. I do not know what I would expect for RTL, but it also appears that those values are inverted when switching.

💻 Repro or Code Sample

Code: Screen Shot 2021-08-11 at 11 26 28 AM

LTR vertical result: Screen Shot 2021-08-11 at 11 26 22 AM

RTL vertical result: Screen Shot 2021-08-11 at 11 26 43 AM

🤔 Expected Behavior

I would expect the current result for LTR to be the RTL and vice versa.

janechu avatar Aug 11 '21 18:08 janechu

Thanks for this @janechu, definitely something to address!

I did have one question - would we expect changes here for RTL/LTR for vertical or would you expect it to be the same given the vertical orientation. I think for vertical orientations I expect it to be the same.

chrisdholt avatar Sep 29 '21 02:09 chrisdholt

this appears to be fixed, but the minimum value remains top. Based on what I'm seeing elsewhere I think @janechu is right. the minimum should be at the bottom.

eljefe223 avatar Feb 07 '22 18:02 eljefe223

I am experiencing the same issue. The vertical slider is upside-down so that the minimum values are at the top and max are at the bottom. Is there an attribute to reverse the direction?

JordanMarr avatar May 19 '22 18:05 JordanMarr