edit icon indicating copy to clipboard operation
edit copied to clipboard

Next input system (#332) draft

Open diabloproject opened this issue 6 months ago • 2 comments

Draft for https://github.com/microsoft/edit/issues/332 Ignore the keyge variable name, I don't know how to name it yet. For now, I made draw_editor.rs:draw_goto_menu work, so I can play with implementation. Migrationot this system does not require us ot migrate the whole editor at once. All feedback is highly appreciated!

Btw @lhecker, can you clean up my previous attempts on creating a proper PR? I suck at git so hard...

diabloproject avatar May 29 '25 19:05 diabloproject

It's not really possible to delete PRs, but it's fine. If you have any specific questions regarding git, please let me know (e.g. how to forcefully update a branch with your local changes, etc.).

Please feel free to just keep pushing into your branch though. When we merge this, we'll "squash" (flatten) its entire history into a single commit anyway. 🙂

lhecker avatar May 30 '25 11:05 lhecker

e.g. how to forcefully update a branch with your local changes, etc.

Yeah,I tried to filter-branch replace my email, which resulted in my pr having whole commit history...

Right now I want to get some feedback on:

  • Is this implementation reasonable?
  • Any fundamental API changes that have to be done?
  • Generally, will this work in your opinion?

diabloproject avatar May 30 '25 18:05 diabloproject